explain the usage of exp and iat jwt claims #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
mprorock,
selfissued,
OR13 and
David-Chadwick
David-Chadwick
suggested changes
Sep 9, 2023
index.html
Outdated
| @@ -600,6 +600,13 @@ <h2>Protected Header Parameters</h2> | |||
| <code>alg</code>, <code>iat</code>, | |||
| <code>exp</code> and <code>cnf</code>. | |||
| </p> | |||
| <p> | |||
| When <code>exp</code> or <code>exp</code> JWT claims are present, | |||
There was a problem hiding this comment.
there is a typo here. Replace first exp with iat
Sakurann
commented
Sep 10, 2023
David-Chadwick
suggested changes
Sep 10, 2023
index.html
Outdated
| they represent issuance and expiration time of a signature, respectively. | ||
| Note that this is different from <code>validFrom</code> and <code>validUntil</code> | ||
| defined in <a data-cite="VC-DATA-MODEL#validity-period">Validity Period</a> | ||
| that represent validity of the data that is being secured. |
There was a problem hiding this comment.
that represents the validity...
selfissued
approved these changes
Sep 11, 2023
OR13
approved these changes
Sep 11, 2023
TallTed
requested changes
Sep 11, 2023
index.html
Outdated
| <p> | ||
| When <code>iat</code> or <code>exp</code> JWT claims are present, | ||
| they represent issuance and expiration time of a signature, respectively. | ||
| Note that this is different from <code>validFrom</code> and <code>validUntil</code> |
There was a problem hiding this comment.
Suggested change
| Note that this is different from <code>validFrom</code> and <code>validUntil</code> | |
| Note that these are different from the <code>validFrom</code> and <code>validUntil</code> |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
(requested re-review by @selfissued by mistake..) |
selfissued
approved these changes
Sep 13, 2023
David-Chadwick
approved these changes
Sep 13, 2023
TallTed
approved these changes
Sep 14, 2023
dlongley
approved these changes
Sep 14, 2023
|
The issue was discussed in a meeting on 2023-09-14
View the transcript6.3. explain the usage of exp and iat jwt claims (pr vc-jose-cose#151)See github pull request vc-jose-cose#151. Kristina Yasuda: please open issues before merging that PR. Michael Jones: this PR clarifies how iat/exp should be used. very small. Manu Sporny: +1 to this PR. makes good distinction between dates associated with proof and VCs. +1 to merge. Brent Zundel: no objections. open for more then a week - merge it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #133.
partially addresses issue #39 though does not give clarity what is mandated, yet.
Preview | Diff