-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add guidance on kid #153
add guidance on kid #153
Conversation
index.html
Outdated
</p> | ||
<p> | ||
<code>kid</code> MUST be present when the key of the <a data-cite="VC-DATA-MODEL#dfn-issuers">issuer</a> | ||
or <a data-cite="VC-DATA-MODEL#dfn-subjects">subject</a> is expressed as a DID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to specify the exact format that we expect here... DID URL -- but is this a relative (frament-only thing) or a fully qualified DID URL (DID URL + fragment). What issue is dealing w/ this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msporny I added a link to your comment here: #117 (comment)
To hold the issue open until its addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msporny I added a link to your comment here: #117 (comment)
To hold the issue open until its addressed.
The issue was discussed in a meeting on 2023-09-14
View the transcript6.4. add guidance on kid (pr vc-jose-cose#153)See github pull request vc-jose-cose#153. Michael Jones: similarly simple. this simplifies one sentence and adds another one. kid must be present when issuer is expressed as a DID. Manu Sporny: i think current text as-is is probably ok, except 2 things - we still have an issue in core data model. does not say what is the value of kid, tho seems to assume it is a DID. some assume it is a relative DID. other implementers put absolute DIDs. probably need to specify which one. Michael Jones: from a conversation earlier where we agreed that kid is a string. so intentionally not making a decision. Kristina Yasuda: there is a separate issued on absolute vs relative DID. Joe Andrieu: calling it DID URL is better. will make a suggestion. |
Co-authored-by: Joe Andrieu <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@Sakurann I applied a few small suggestions, but this question remains: #153 (comment) |
should align with PR #144 better
issue #117.
Preview | Diff