Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guidance on kid #153

Merged
merged 4 commits into from
Sep 20, 2023
Merged

add guidance on kid #153

merged 4 commits into from
Sep 20, 2023

Conversation

Sakurann
Copy link
Contributor

@Sakurann Sakurann commented Sep 9, 2023

should align with PR #144 better

issue #117.

  • add pointer to the guidance on kid in rfc7515.
  • clarify that kid can be present only in the header.
  • mandate kid when DIDs are used (need to add reference to a DID-Core)

Preview | Diff

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated
</p>
<p>
<code>kid</code> MUST be present when the key of the <a data-cite="VC-DATA-MODEL#dfn-issuers">issuer</a>
or <a data-cite="VC-DATA-MODEL#dfn-subjects">subject</a> is expressed as a DID.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to specify the exact format that we expect here... DID URL -- but is this a relative (frament-only thing) or a fully qualified DID URL (DID URL + fragment). What issue is dealing w/ this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msporny I added a link to your comment here: #117 (comment)

To hold the issue open until its addressed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msporny I added a link to your comment here: #117 (comment)

To hold the issue open until its addressed.

index.html Outdated Show resolved Hide resolved
@iherman
Copy link
Member

iherman commented Sep 15, 2023

The issue was discussed in a meeting on 2023-09-14

  • no resolutions were taken
View the transcript

6.4. add guidance on kid (pr vc-jose-cose#153)

See github pull request vc-jose-cose#153.

Michael Jones: similarly simple. this simplifies one sentence and adds another one. kid must be present when issuer is expressed as a DID.
� 6 approvals no objections.

Manu Sporny: i think current text as-is is probably ok, except 2 things - we still have an issue in core data model. does not say what is the value of kid, tho seems to assume it is a DID. some assume it is a relative DID. other implementers put absolute DIDs. probably need to specify which one.
� this seem to assume absolute DID with an entire DID.

Michael Jones: from a conversation earlier where we agreed that kid is a string. so intentionally not making a decision.

Kristina Yasuda: there is a separate issued on absolute vs relative DID.
� the purpose is to address the issue in another PR.

Joe Andrieu: calling it DID URL is better. will make a suggestion.

index.html Outdated Show resolved Hide resolved
@w3c w3c deleted a comment from bob420-svg Sep 18, 2023
OR13 and others added 2 commits September 18, 2023 08:24
Co-authored-by: Joe Andrieu <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@OR13
Copy link
Contributor

OR13 commented Sep 18, 2023

@Sakurann I applied a few small suggestions, but this question remains: #153 (comment)

@selfissued selfissued merged commit 762eb4d into main Sep 20, 2023
1 check passed
@decentralgabe decentralgabe deleted the kid-guidance branch February 26, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants