Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Correct Names for Things #156

Merged
merged 7 commits into from
Sep 21, 2023
Merged

Conversation

selfissued
Copy link
Collaborator

@selfissued selfissued commented Sep 13, 2023

This replaces uses of non-standard names like "claimset" and inaccurate IANA registry names with the actual names from the specifications. It also clarifies how many of the things named are used to align with the referenced specifications.


Preview | Diff

@selfissued selfissued added the editorial Editorial changes only label Sep 13, 2023
Copy link
Contributor

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iherman
Copy link
Member

iherman commented Sep 15, 2023

The issue was discussed in a meeting on 2023-09-14

  • no resolutions were taken
View the transcript

6.6. Use Correct Names for Things (pr vc-jose-cose#156)

See github pull request vc-jose-cose#156.

Michael Jones: last PR. editorial. fixes things that should have been fixed.

Brent Zundel: action is to review.

Manu Sporny: PR looks good, in general, good to call things by the right name.

Brent Zundel: nothing controversial, expect to go in in few days.

Joe Andrieu: Also, Kristina, I'm not sure I answered your earlier question correctly. A purely relative component would only make sense if the base is set to the DID. "#key1" would only make sense if you're in a context where the base is well-defined and hence maps to a fully qualified URL. So, if the fragment is in a DID Document, we're all good.

Manu Sporny: yes, what Joe said above ^ relative URLs only work when you're in a DID Document.

Manu Sporny: but it's not clear if that works for everwhere we'd find a kid.

Kristina Yasuda: thank you, Joe!

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@OR13
Copy link
Contributor

OR13 commented Sep 18, 2023

@selfissued conflicts exist, you may want to address them before applying suggestions

selfissued and others added 4 commits September 20, 2023 14:41
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
index.html Outdated Show resolved Hide resolved
@selfissued selfissued merged commit 1f69b7a into w3c:main Sep 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants