Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update COSE Examples to use EDN #258

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Update COSE Examples to use EDN #258

merged 6 commits into from
Mar 18, 2024

Conversation

decentralgabe
Copy link
Collaborator

@decentralgabe decentralgabe commented Mar 16, 2024

Copy link
Collaborator

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The annotated examples are much more readable! Thanks.

@decentralgabe
Copy link
Collaborator Author

there is a build error pertaining to the EDN lib generating HTML in a way that breaks the W3C lint checker

"file:/home/runner/work/vc-jose-cose/vc-jose-cose.w3c/index.html":1666.3-1666.9: error: Element “style” not allowed as child of element “section” in this context. (Suppressing further errors from this subtree.)
"file:/home/runner/work/vc-jose-cose/vc-jose-cose.w3c/index.html":1684.26-1684.29: error: Element “dl” not allowed as child of element “dl” in this context. (Suppressing further errors from this subtree.)
"file:/home/runner/work/vc-jose-cose/vc-jose-cose.w3c/index.html":1691.64-1691.67: error: Element “dl” not allowed as child of element “dl” in this context. (Suppressing further errors from this subtree.)
"file:/home/runner/work/vc-jose-cose/vc-jose-cose.w3c/index.html":1690.5-1690.36: info warning: Section lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all sections, or else use a “div” element instead for any cases where no heading is needed.

I am going to merge as-is and consider making the examples statically generated in a follow-up issue.

@decentralgabe
Copy link
Collaborator Author

#259

@decentralgabe decentralgabe merged commit dd696c7 into main Mar 18, 2024
1 of 2 checks passed
@decentralgabe decentralgabe deleted the cose-examples-fix branch March 18, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COSE algorithms and examples not specified
2 participants