Skip to content

apg/explicit-row-role-removal generated by aria-practices #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

apg/explicit-row-role-removal generated by aria-practices #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90cd431
chore: Update branch with latest `explicit-row-role-removal` changes …
w3cgruntbot Jun 7, 2025
6b19f7c
chore: Update branch with latest `explicit-row-role-removal` changes …
w3cgruntbot Jun 7, 2025
d9d6a96
chore: Update branch with latest `explicit-row-role-removal` changes …
w3cgruntbot Jun 7, 2025
4091eb3
chore: Update branch with latest `explicit-row-role-removal` changes …
w3cgruntbot Jun 7, 2025
b83f906
chore: Update branch with latest `explicit-row-role-removal` changes …
w3cgruntbot Jun 7, 2025
e0ecb48
chore: Update branch with latest `explicit-row-role-removal` changes …
w3cgruntbot Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ARIA/apg/about/coverage-and-quality/coverage-and-quality-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ if (enableSidebar) document.body.classList.add('has-sidebar');

<div>

<p>Page last updated: September 12, 2024</p>
<p>Page last updated: June 7, 2025</p>
<section>
<h2>About These Reports</h2>
<p>
Expand Down Expand Up @@ -652,7 +652,6 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
<li><a href="../../patterns/combobox/examples/grid-combo/">Editable Combobox with Grid Popup</a></li>
<li><a href="../../patterns/grid/examples/layout-grids/">Layout Grid</a></li>
<li><a href="../../patterns/table/examples/table/">Table</a></li>
<li><a href="../../patterns/treegrid/examples/treegrid-1/">Treegrid Email Inbox</a></li>
</ul>
</td>
</tr>
Expand Down Expand Up @@ -2142,8 +2141,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
<td></td>
<td></td>
<td>ex1</td>
<td>3</td>
<td>3</td>
<td>2</td>
<td>2</td>
<td>7</td>
<td>5</td>
<td>aria-activedescendant,aria-current</td>
Expand Down
1 change: 0 additions & 1 deletion ARIA/apg/index/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,6 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
<li><a href="../patterns/combobox/examples/grid-combo/">Editable Combobox with Grid Popup</a></li>
<li><a href="../patterns/grid/examples/layout-grids/">Layout Grid</a></li>
<li><a href="../patterns/table/examples/table/">Table</a></li>
<li><a href="../patterns/treegrid/examples/treegrid-1/">Treegrid Email Inbox</a></li>
</ul>
</td>
</tr>
Expand Down
29 changes: 9 additions & 20 deletions ARIA/apg/patterns/treegrid/examples/treegrid-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permalink: /ARIA/apg/patterns/treegrid/examples/treegrid-1/

sidebar: true

footer: " <div class='example-page-footer'> <p><a href='https://github.com/orgs/w3c/projects/117'>View issues related to this example</a></p> <p>Page last updated: 18 March 2025</p> </div> "
footer: " <div class='example-page-footer'> <p><a href='https://github.com/orgs/w3c/projects/117'>View issues related to this example</a></p> <p>Page last updated: 7 June 2025</p> </div> "

# Context here: https://github.com/w3c/wai-aria-practices/issues/31
type_of_guidance: APG
Expand Down Expand Up @@ -178,42 +178,42 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
</tr>
</thead>
<tbody>
<tr role="row" aria-level="1" aria-posinset="1" aria-setsize="1" aria-expanded="true">
<tr aria-level="1" aria-posinset="1" aria-setsize="1" aria-expanded="true">
<td role="gridcell">Treegrids are awesome</td>
<td role="gridcell">Want to learn how to use them?</td>
<td role="gridcell"><a href="mailto:[email protected]">[email protected]</a></td>
</tr>
<tr role="row" aria-level="2" aria-posinset="1" aria-setsize="3">
<tr aria-level="2" aria-posinset="1" aria-setsize="3">
<td role="gridcell">re: Treegrids are awesome</td>
<td role="gridcell">I agree with you, they are the shizzle</td>
<td role="gridcell"><a href="mailto:[email protected]">[email protected]</a></td>
</tr>
<tr role="row" aria-level="2" aria-posinset="2" aria-setsize="3" aria-expanded="false">
<tr aria-level="2" aria-posinset="2" aria-setsize="3" aria-expanded="false">
<td role="gridcell">re: Treegrids are awesome</td>
<td role="gridcell">They are great for showing a lot of data, like a grid</td>
<td role="gridcell"><a href="mailto:[email protected]">[email protected]</a></td>
</tr>
<tr role="row" aria-level="3" aria-posinset="1" aria-setsize="1" class="hidden">
<tr aria-level="3" aria-posinset="1" aria-setsize="1" class="hidden">
<td role="gridcell">re: Treegrids are awesome</td>
<td role="gridcell">Cool, we've been needing an example and documentation</td>
<td role="gridcell"><a href="mailto:[email protected]">[email protected]</a></td>
</tr>
<tr role="row" aria-level="2" aria-posinset="3" aria-setsize="3" aria-expanded="false">
<tr aria-level="2" aria-posinset="3" aria-setsize="3" aria-expanded="false">
<td role="gridcell">re: Treegrids are awesome</td>
<td role="gridcell">I hear the Fancytree library is going to align with this example!</td>
<td role="gridcell"><a href="mailto:[email protected]">[email protected]</a></td>
</tr>
<tr role="row" aria-level="3" aria-posinset="1" aria-setsize="1" aria-expanded="false" class="hidden">
<tr aria-level="3" aria-posinset="1" aria-setsize="1" aria-expanded="false" class="hidden">
<td role="gridcell">re: Treegrids are awesome</td>
<td role="gridcell">Sometimes they are more like trees, others are more like grids</td>
<td role="gridcell"><a href="mailto:[email protected]">[email protected]</a></td>
</tr>
<tr role="row" aria-level="4" aria-posinset="1" aria-setsize="2" class="hidden">
<tr aria-level="4" aria-posinset="1" aria-setsize="2" class="hidden">
<td role="gridcell">re: Treegrids are awesome</td>
<td role="gridcell">Cool, when it's a tree, let's keep left/right to collapse/expand</td>
<td role="gridcell"><a href="mailto:[email protected]">[email protected]</a></td>
</tr>
<tr role="row" aria-level="4" aria-posinset="2" aria-setsize="2" class="hidden">
<tr aria-level="4" aria-posinset="2" aria-setsize="2" class="hidden">
<td role="gridcell">re: Treegrids are awesome</td>
<td role="gridcell">I see, sometimes right arrow moves by column</td>
<td role="gridcell"><a href="mailto:[email protected]">[email protected]</a></td>
Expand Down Expand Up @@ -393,17 +393,6 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
<td><code>table</code></td>
<td>Provides an accessible name for the <code>treegrid</code>.</td>
</tr>
<tr data-test-id="row-role">
<th scope="row"><code>row</code></th>
<td></td>
<td><code>tr</code></td>
<td>
<ul>
<li>Identifies the element as a <code>row</code>.</li>
<li>The <code>row</code> role is not an implicit semantic for the <code>tr</code> element when in a <code>treegrid</code>.</li>
</ul>
</td>
</tr>
<tr data-test-id="row-tabindex">
<td></td>
<th scope="row"><code>tabindex="-1"</code></th>
Expand Down
8 changes: 4 additions & 4 deletions ARIA/apg/patterns/treegrid/treegrid-pattern.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,18 +301,18 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
<h2>WAI-ARIA Roles, States, and Properties</h2>
<ul>
<li>The treegrid container has role <a href="https://w3c.github.io/aria/#treegrid" class="role-reference">treegrid</a>.</li>
<li>Each row container has role <a href="https://w3c.github.io/aria/#row" class="role-reference">row</a> and is either a DOM descendant of or owned by the <code>treegrid</code> element or an element with role <a href="https://w3c.github.io/aria/#rowgroup" class="role-reference">rowgroup</a>.</li>
<li>Each row container has an implicit role of <a href="https://w3c.github.io/aria/#row" class="role-reference">row</a> and is either a DOM descendant of or owned by the <code>treegrid</code> element or an element with role <a href="https://w3c.github.io/aria/#rowgroup" class="role-reference">rowgroup</a>.</li>
<li>
Each cell is either a DOM descendant of or owned by a <code>row</code> element and has one of the following roles:
Each cell is either a DOM descendant of or owned by a row element and has one of the following roles:
<ul>
<li><a href="https://w3c.github.io/aria/#columnheader" class="role-reference">columnheader</a> if the cell contains a title or header information for the column.</li>
<li><a href="https://w3c.github.io/aria/#rowheader" class="role-reference">rowheader</a> if the cell contains title or header information for the row.</li>
<li><a href="https://w3c.github.io/aria/#gridcell" class="role-reference">gridcell</a> if the cell does not contain column or row header information.</li>
</ul>
</li>
<li>
A <code>row</code> that can be expanded or collapsed to show or hide a set of child rows is a parent row.
Each parent <code>row</code> has the <a class="property-reference" href="https://w3c.github.io/aria/#aria-expanded">aria-expanded</a> state set on either the <code>row</code> element or on a cell contained in the<code>row</code>.
A row that can be expanded or collapsed to show or hide a set of child rows is a parent row.
Each parent row has the <a class="property-reference" href="https://w3c.github.io/aria/#aria-expanded">aria-expanded</a> state set on either the row element or on a cell contained in the row.
The <code>aria-expanded</code> state is set to <code>false</code> when the child rows are not displayed and set to <code>true</code> when the child rows are displayed.
Rows that do not control display of child rows do not have the <code>aria-expanded</code> attribute because, if they were to have it, they would be incorrectly described to assistive technologies as parent rows.
</li>
Expand Down
2 changes: 1 addition & 1 deletion _external/aria-practices
Open in desktop
Submodule aria-practices updated 6 files
+2 −3 content/about/coverage-and-quality/coverage-and-quality-report.html
+1 −1 content/about/coverage-and-quality/role-coverage.csv
+0 −1 content/index/index.html
+8 −19 content/patterns/treegrid/examples/treegrid-1.html
+4 −4 content/patterns/treegrid/treegrid-pattern.html
+6 −10 test/tests/treegrid_treegrid-1.js
2 changes: 1 addition & 1 deletion content-assets/wai-aria-practices/about/coverage-and-quality/role-coverage.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"radio","3","4","Guidance: Radio Group Pattern","Guidance: For Radio Groups Not Contained in a Toolbar","Guidance: For Radio Group Contained in a Toolbar","Example: Radio Group Using aria-activedescendant","Example: Rating Radio Group","Example: Radio Group Using Roving tabindex","Example: Toolbar"
"radiogroup","0","4","Example: Radio Group Using aria-activedescendant","Example: Rating Radio Group","Example: Radio Group Using Roving tabindex","Example: Toolbar"
"region","1","6","Guidance: Region","Example: Accordion","Example: Auto-Rotating Image Carousel with Buttons for Slide Control","Example: Auto-Rotating Image Carousel with Tabs for Slide Control","Example: Navigation Menubar","Example: Navigation Treeview","Example: Region Landmark"
"row","0","4","Example: Editable Combobox with Grid Popup","Example: Layout Grid","Example: Table","Example: Treegrid Email Inbox"
"row","0","3","Example: Editable Combobox with Grid Popup","Example: Layout Grid","Example: Table"
"rowgroup","0","1","Example: Table"
"rowheader","0","0"
"scrollbar","0","0"
Expand Down