-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create aria25.html #4061
base: main
Are you sure you want to change the base?
Create aria25.html #4061
Conversation
The technique extracted from the longer general technique
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mbgower There are some examples or links to your C drive, and links to WCAG 2.1, could you update that? Assuming this technique is still worthwhile? |
renumbering previously created technique, since there is now already an ARIA24 technique
removing reference to working example
remove non-existent working example reference
I couldn't find the working examples, so removed the references. I think this technique is still useful, so am adding it to Drafted |
Hmm, getting some check failures. I'll have to return to this... |
Discussed on backlog call 11/1. @stevefaulkner volunteered to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Double-check
<p class="instructions">
elements - some of them are likely meant to be kept but should no longer have the class; others should be entirely removed. - Make sure code examples are indented for readability and have proper class applied for syntax highlighting.
- Make sure any related SCs link to this from their Understanding page, so that the About this Technique box fills in correctly.
- Filename should be uppercase; I will fix this since it is easier for me to do so on my case-sensitive filesystem.
Check preview at https://deploy-preview-4061--wcag2.netlify.app/techniques/aria/aria25
This branch never had a pull request made. Suggest we either take it, or delete the PR and branch.
If we do think it's a valuable new technique, it'll need to be renumbered, as there is already an ARIA24