Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create aria25.html #4061

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Create aria25.html #4061

wants to merge 7 commits into from

Conversation

patrickhlauke
Copy link
Member

This branch never had a pull request made. Suggest we either take it, or delete the PR and branch.

If we do think it's a valuable new technique, it'll need to be renumbered, as there is already an ARIA24

The technique extracted from the longer general technique
Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 69c00b1
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/6785531a47d5d400085276d3
😎 Deploy Preview https://deploy-preview-4061--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alastc alastc requested review from giacomo-petri and fstrr October 4, 2024 15:43
@alastc
Copy link
Contributor

alastc commented Oct 4, 2024

@mbgower There are some examples or links to your C drive, and links to WCAG 2.1, could you update that? Assuming this technique is still worthwhile?

@mbgower mbgower changed the title Create aria24.html Create aria25.html Oct 29, 2024
renumbering previously created technique, since there is now already an ARIA24 technique
removing reference to working example
remove non-existent working example reference
@mbgower
Copy link
Contributor

mbgower commented Oct 29, 2024

@mbgower There are some examples or links to your C drive, and links to WCAG 2.1, could you update that? Assuming this technique is still worthwhile?

I couldn't find the working examples, so removed the references. I think this technique is still useful, so am adding it to Drafted

@mbgower
Copy link
Contributor

mbgower commented Oct 29, 2024

Hmm, getting some check failures. I'll have to return to this...

@mbgower mbgower assigned stevefaulkner and unassigned mbgower Nov 1, 2024
@bruce-usab
Copy link
Contributor

Discussed on backlog call 11/1. @stevefaulkner volunteered to review.

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Double-check <p class="instructions"> elements - some of them are likely meant to be kept but should no longer have the class; others should be entirely removed.
  • Make sure code examples are indented for readability and have proper class applied for syntax highlighting.
  • Make sure any related SCs link to this from their Understanding page, so that the About this Technique box fills in correctly.
  • Filename should be uppercase; I will fix this since it is easier for me to do so on my case-sensitive filesystem.

Check preview at https://deploy-preview-4061--wcag2.netlify.app/techniques/aria/aria25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants