ci: introduce pre-commit integration #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 16, 2023 12:09
OrKoN
approved these changes
Nov 16, 2023
|
Just to note another follow-up: This is a much simpler version than the previous PR attempt, taking #442 (review) into account. No linting is being done to the CDDL at this time. |
github-actions bot
added a commit
that referenced
this pull request
Nov 16, 2023
SHA: 0f93124 Reason: push, by thiagowfx Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thanks. That's great to see in action now! |
OrKoN
pushed a commit
that referenced
this pull request
Nov 27, 2023
* ci: introduce pre-commit integration Follow-up-of: #442 * fix trailing whitespace * add shellcheck, codespell * fix spelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up-of: #442
At the very least, this should help eliminate bikeshedding of trailing whitespace and English spelling.
There's no need to install anything locally. This will show up as an optional (non-blocking) check / action in future PRs.
Bug: #186
Preview | Diff