Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce recommendations for external specification modules #605

Merged
merged 9 commits into from
Nov 22, 2023

Conversation

thiagowfx
Copy link
Member

@thiagowfx thiagowfx commented Nov 16, 2023

Bug: #506, #587


Preview | Diff

@thiagowfx thiagowfx requested a review from OrKoN November 16, 2023 16:01
@thiagowfx
Copy link
Member Author

@OrKoN I'm not quite sure what we really want to add here...

(from the discussions on w3c/permissions#425)

Thoughts?

(Corresponding WG meeting discussion: #587 (comment))

Copy link
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not what we want. Let me come back to this tomorrow.

@OrKoN OrKoN self-assigned this Nov 16, 2023
@jgraham
Copy link
Member

jgraham commented Nov 17, 2023

There are two different things here:

  • Open specifications, which can in principle define whatever they want. However we can suggest they they should avoid extending existing commands or modules where possible (i.e. prefer to add new modules; for extending existing modules updating the source specification of the existing module is preferred), and never define names including a colon.
  • Implementations. For implementations we want to define that they must not add additional modules or extend new modules unless the added modules, commands, events, or properties have a correctly prefixed name (i.e. one that contains a :).

@thiagowfx thiagowfx changed the title DRAFT: Expand extensions modules recommendation Introduce recommendations for external specification modules Nov 17, 2023
@thiagowfx thiagowfx requested a review from OrKoN November 17, 2023 14:08
@thiagowfx thiagowfx marked this pull request as ready for review November 17, 2023 14:08
@thiagowfx
Copy link
Member Author

Previously:

When defining [=extension modules=], implementers should consider the
possibility of future standardization of the module. If the module is
likely to be standardized in the future, implementers should use a
[=module name=] that does not contain a colon ":" character.

@thiagowfx thiagowfx force-pushed the thiagowfx/extensions branch 2 times, most recently from be5670b to 6a2ece9 Compare November 17, 2023 14:10
index.bs Outdated Show resolved Hide resolved
@thiagowfx thiagowfx force-pushed the thiagowfx/extensions branch 2 times, most recently from 0df51d6 to b9aa2b0 Compare November 17, 2023 14:12
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@thiagowfx thiagowfx requested a review from OrKoN November 17, 2023 14:13
index.bs Outdated Show resolved Hide resolved
Thiago Perrotta and others added 2 commits November 17, 2023 15:24
@thiagowfx thiagowfx requested a review from OrKoN November 17, 2023 14:27
Copy link
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Thiago Perrotta and others added 2 commits November 21, 2023 18:31
index.bs Outdated Show resolved Hide resolved
Co-authored-by: Alex Rudenko <[email protected]>
index.bs Outdated Show resolved Hide resolved
@thiagowfx thiagowfx merged commit 829057e into main Nov 22, 2023
5 checks passed
@thiagowfx thiagowfx deleted the thiagowfx/extensions branch November 22, 2023 10:03
github-actions bot added a commit that referenced this pull request Nov 22, 2023
SHA: 829057e
Reason: push, by thiagowfx

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
OrKoN added a commit that referenced this pull request Nov 27, 2023
* Introduce recommendations for external specification modules

Bug: #506, #587

* Update index.bs

Co-authored-by: Alex Rudenko <[email protected]>

* remove external spec dfn

* Update index.bs

Co-authored-by: jgraham <[email protected]>

* Update index.bs

* remove paragraph

* linkify command names and event names

* Update index.bs

Co-authored-by: Alex Rudenko <[email protected]>

* define -> extend

---------

Co-authored-by: Alex Rudenko <[email protected]>
Co-authored-by: jgraham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants