Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User prompt handler capabilities #1791

Merged
merged 9 commits into from
Apr 3, 2024
Merged

Commits on Mar 11, 2024

  1. Rewrite the user prompt handler configuration to allow overrides

    The idea is that for BiDi we'll accept objects like:
    
    {
      "alert": "dismiss",
      "beforeUnload": "ignore"
    }
    
    to allow different handling per prompt type, whilst falling back to
    the appropiate defaults to maintain the current behaviour for
    implementations that don't support BiDi.
    jgraham committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    3922f56 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Henrik Skupin <[email protected]>
    jgraham and whimboo committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    124f590 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8837693 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0ba57a6 View commit details
    Browse the repository at this point in the history
  5. Fix warnings

    jgraham committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    c5dfabc View commit details
    Browse the repository at this point in the history
  6. Fix review issues

    jgraham committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    6a39106 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    e5c30f5 View commit details
    Browse the repository at this point in the history
  2. Allow the possibility of multiple user prompts

    The specifications allow one prompt per event loop, so instead of
    assuming a single current user prompt, allow getting the user
    prompt for the active browsing context's event loop.
    jgraham committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    05d25b2 View commit details
    Browse the repository at this point in the history
  3. Conver TODO into comment

    jgraham committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    954309f View commit details
    Browse the repository at this point in the history