-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User prompt handler capabilities #1791
Merged
Merged
Commits on Mar 11, 2024
-
Rewrite the user prompt handler configuration to allow overrides
The idea is that for BiDi we'll accept objects like: { "alert": "dismiss", "beforeUnload": "ignore" } to allow different handling per prompt type, whilst falling back to the appropiate defaults to maintain the current behaviour for implementations that don't support BiDi.
Configuration menu - View commit details
-
Copy full SHA for 3922f56 - Browse repository at this point
Copy the full SHA 3922f56View commit details -
Apply suggestions from code review
Co-authored-by: Henrik Skupin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 124f590 - Browse repository at this point
Copy the full SHA 124f590View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8837693 - Browse repository at this point
Copy the full SHA 8837693View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ba57a6 - Browse repository at this point
Copy the full SHA 0ba57a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5dfabc - Browse repository at this point
Copy the full SHA c5dfabcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a39106 - Browse repository at this point
Copy the full SHA 6a39106View commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e5c30f5 - Browse repository at this point
Copy the full SHA e5c30f5View commit details -
Allow the possibility of multiple user prompts
The specifications allow one prompt per event loop, so instead of assuming a single current user prompt, allow getting the user prompt for the active browsing context's event loop.
Configuration menu - View commit details
-
Copy full SHA for 05d25b2 - Browse repository at this point
Copy the full SHA 05d25b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 954309f - Browse repository at this point
Copy the full SHA 954309fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.