Don't require user prompt handler notify to match when creating session #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would prevent creating a BiDi session for a browser that already has a HTTP session with the notify flag set for some prompt handler.
OrKoN
approved these changes
Jun 12, 2024
whimboo
reviewed
Jun 13, 2024
jgraham
force-pushed
the
prompt_handler_notify
branch
from
add07f9
to
d95609c
Compare
whimboo
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would prevent creating a BiDi session for a browser that already has a HTTP session with the notify flag set for some prompt handler.
Preview | Diff