Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some small problems with set window rect changes #1832

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

jgraham
Copy link
Member

@jgraham jgraham commented Jul 17, 2024

  • Restore handling both missing and null values for parameters.

  • Fix some grammar errors.


Preview | Diff

* Restore handling both missing and null values for parameters.

* Fix some grammar errors.
@jgraham jgraham requested review from whimboo and OrKoN July 17, 2024 12:55
@whimboo
Copy link
Contributor

whimboo commented Jul 17, 2024

This is a follow-up fix for #1830 and contributes to a final solution for issues as covered on #1826.

Copy link
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looked like commas are needed in the if statements

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. I was already wondering about the removal but didn't notice that we missed those cases. Beside what @OrKoN already mentioned it looks good to me. Thanks.

@jgraham jgraham merged commit 57eb5e9 into master Jul 17, 2024
2 checks passed
@jgraham jgraham deleted the set_window_rect_fixups branch July 17, 2024 14:03
github-actions bot added a commit that referenced this pull request Jul 17, 2024
SHA: 57eb5e9
Reason: push, by jgraham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants