Introduce RTCEncodedFrameMetadata dictionary #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
force-pushed
the
introduce-RTCEncodedFrameMetadata
branch
from
7ff6427 to
f834681
Compare
guidou
approved these changes
May 8, 2025
jan-ivar
reviewed
May 8, 2025
| @@ -369,22 +465,14 @@ enum RTCEncodedVideoFrameType { | |||
|
|
|||
| ## <dfn dictionary>RTCEncodedVideoFrameMetadata</dfn> dictionary ## {#RTCEncodedVideoFrameMetadata} | |||
| <pre class="idl"> | |||
| dictionary RTCEncodedVideoFrameMetadata { | |||
| dictionary RTCEncodedVideoFrameMetadata : RTCEncodedFrameMetadata { | |||
There was a problem hiding this comment.
Is this PR solely a plain move of members?
Note that moving members to a base dictionary technically is JS-observable in a small way: it likely changes the lexicographical order of members, but I doubt this will have any impact, so I like this change (provided it is a plain move)
There was a problem hiding this comment.
Yes it is a plain move
jan-ivar
approved these changes
May 15, 2025
|
Landing now that conflict has been fixed. |
github-actions bot
added a commit
that referenced
this pull request
May 15, 2025
SHA: 73c5464 Reason: push, by youennf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
Preview | Diff