Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RTCIceCandidatePair interface in RTCIceTransport #205

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Apr 18, 2024

  1. Use RTCIceCandidatePair interface in RTCIceTransport.

    Addresses: w3c/webrtc-pc#2930.
    
    As an interface, RTCIceCandidatePair can be used as an attribute of
    other interfaces.
    
    So simplify RTCIceCandidatePairEvent by having a single candidatePair
    attribute instead of individual local and remote candidates.
    sam-vi committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    6d8a75a View commit details
    Browse the repository at this point in the history
  2. Compare RTCIceCandidatePair identity instead of match algo.

    An application only acquires objects of RTCIceCandidatePair through
    RTCIceTransport events and getSelectedCandidatePair().
    
    So simplify input validation where RTCIceCandidatePair is used as an
    argument by directly comparing object identity instead of using the
    candidate pair match algorithm.
    sam-vi committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1f840b8 View commit details
    Browse the repository at this point in the history
  3. Modify the change of selected pair algo in RTCIceTransport.

    This ensures that each candidate pair has a unique identity, simplifying
    the validation of RTCIceCandidatePair arguments to RTCIceTransport
    methods.
    sam-vi committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d73eaa8 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    2de721f View commit details
    Browse the repository at this point in the history