Add WebRTC-specific interactions with capture/receive/RTP timestamps #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handellm
commented
Dec 19, 2024
| <p> | ||
| <!-- TODO: use the xref mechanism when mediacapture-extensions spec status is cleared up. | ||
| See https://github.com/w3c/mediacapture-extensions/issues/132 --> | ||
| The following terms are defined in <a href="https://w3c.github.io/mediacapture-extensions">mediacapture-extensions</a> |
There was a problem hiding this comment.
Due to the unclear state of the mediacapture-extensions spec (not listed in browser-specs) I had to make some temporary reference structure as per below, when referring to concepts defined there.
alvestrand
reviewed
Dec 19, 2024
alvestrand
reviewed
Dec 19, 2024
|
Ping @handellm |
…rmative as things should be observable.
|
@alvestrand please take another look! |
henbos
approved these changes
Jan 10, 2025
|
Looked at in editors meeting Feb 27; will discuss again next week. |
jan-ivar
reviewed
Mar 6, 2025
Comment on lines
+1558
to
+1561
| <h2>RTCRtpSender video track frame timestamp effects on outgoing packet NTP and RTP timestamps</h2> | ||
| <p> | ||
| The user agent defines a <dfn class="export">frame timestamp</dfn> being the same as the [=capture timestamp=] | ||
| of the frame being produced on the {{RTCRtpSender}} {{MediaStreamTrack}} if it is set. |
There was a problem hiding this comment.
Sorry, I'm not following what this timestamp is by the name "frame timestamp". Not all track sources will insert capture timestamps in the tracks they produce. Is this what you mean by "if it is set"?
Comment on lines
+1562
to
+1563
| If it is unset the user agent MUST estimate a timestamp from the sent frame's [=presentation timestamp=] together with the | ||
| time it was received by the {{RTCRtpSender}}. This estimate MUST NOT be based on [= RTP timestamp =]. |
There was a problem hiding this comment.
What does "received by the RTCRtpSender" mean? Do you mean RTCRtpReceiver?
|
replaced by #233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the spec to describe how WebRTC interacts with timestamps added by w3c/mediacapture-extensions#156.
Related to changes needed by w3c/webcodecs#813
Preview | Diff