Skip to content

Commit

Permalink
Add empty RTCEncodeOptions dict and empty encodeOptions argument to s…
Browse files Browse the repository at this point in the history
…etParameters

Both are defined as empty in order to allow webrtc-extensions to extend
them which is done in
  w3c/webrtc-extensions#167
  • Loading branch information
fippo committed Jul 10, 2023
1 parent bc552d5 commit 65ac21e
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 3 deletions.
9 changes: 9 additions & 0 deletions amendments.json
Original file line number Diff line number Diff line change
Expand Up @@ -501,5 +501,14 @@
"status": "candidate",
"id": 34
}
],
"rtcencodeoptions": [
{
"description": "Create empty RTCEncodeOptions to allow for extensibility of setParameters",
"pr": 2885,
"type": "addition",
"status": "candidate",
"id": 35
}
]
}
1 change: 1 addition & 0 deletions base-rec.html
Original file line number Diff line number Diff line change
Expand Up @@ -10102,6 +10102,7 @@ <h5 id="dictionary-rtcrtpheaderextensioncapability-members">
</section>
</div>
</section>
<div id="rtcencodeoptions"></div>
</section>
<section id="rtcrtpreceiver-interface">
<h3 id="x5-3-rtcrtpreceiver-interface"><bdi class="secno">5.3 </bdi>
Expand Down
25 changes: 22 additions & 3 deletions webrtc.html
Original file line number Diff line number Diff line change
Expand Up @@ -8862,7 +8862,8 @@ <h3>
readonly attribute MediaStreamTrack? track;
readonly attribute RTCDtlsTransport? transport;
static RTCRtpCapabilities? getCapabilities(DOMString kind);
Promise&lt;undefined&gt; setParameters(RTCRtpSendParameters parameters);
Promise&lt;undefined&gt; setParameters(RTCRtpSendParameters parameters,
optional sequence&lt;RTCEncodeOptions&gt; encodeOptions = []);
RTCRtpSendParameters getParameters();
Promise&lt;undefined&gt; replaceTrack(MediaStreamTrack? withTrack);
undefined setStreams(MediaStream... streams);
Expand Down Expand Up @@ -8994,8 +8995,9 @@ <h2>
MUST run the following steps:
</p>
<ol class=algorithm id="setparameters-algo">
<li class="no-test-needed">Let <var>parameters</var> be the
method's first argument.
<li id="rtcencodeoptions" class="no-test-needed">Let <var>parameters</var> be the
method's first argument and let <var>encodeOptions</var> be second
argument which is ununsed in this specification and shall be ignored.
</li>
<li class="no-test-needed">Let <var>sender</var> be the
{{RTCRtpSender}} object on which {{setParameters}} is
Expand Down Expand Up @@ -10139,6 +10141,23 @@ <h2>
</section>
</div>
</section>
<div id="rtcencodeoptions"><!-- kept for candidate amendments management purposes --></div>
<section id="rtcencodeoptions">
<h3>
<dfn>RTCEncodeOptions</dfn> Dictionary
</h3>
<div>
<pre class="idl">dictionary RTCEncodeOptions {
};</pre>
</div>
<section>
<h2>Dictionary {{RTCEncodeOptions}} Members</h2>
<p>
RTCEncodeOptions is the WebRTC equivalent of {{VideoEncoderEncodeOptions}} in [[WebCodecs]].
It has no members in this specification but allows for extensibility.
</p>
</section>
</section>
</section>
<section>
<h3>
Expand Down

0 comments on commit 65ac21e

Please sign in to comment.