Skip to content

Commit

Permalink
Make RTCIceCandidatePair members required
Browse files Browse the repository at this point in the history
In webrtc-pc this dictionary is only used as a return type of getSelectedCandidatePair(), which will include both local and remote. This is not a problem.

In https://w3c.github.io/webrtc-extensions/#rtcicetransport the dictionary is used as a non-optional argument, and Web IDL requires that dictionary arguments are optional if there are no required members. Fix this by making them required.
  • Loading branch information
foolip authored Mar 27, 2024
1 parent 252ff88 commit 8ca8cd0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions webrtc.html
Original file line number Diff line number Diff line change
Expand Up @@ -12559,8 +12559,8 @@ <h3>
</h3>
<div>
<pre class="idl">dictionary RTCIceCandidatePair {
RTCIceCandidate local;
RTCIceCandidate remote;
required RTCIceCandidate local;
required RTCIceCandidate remote;
};</pre>
<section>
<h2>
Expand Down

0 comments on commit 8ca8cd0

Please sign in to comment.