Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and complete description of amendments 16, 18, 29, 49 #2993

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Improve and complete description of amendments 16, 18, 29, 49 #2993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7f181f
Fix bogus type for amendment 29
dontcallmedom Aug 30, 2024
89aa4b1
Document more completely amendment 16
dontcallmedom Aug 30, 2024
044a6b3
Add more complete description of amendment 49
dontcallmedom Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 63 additions & 18 deletions amendments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,22 @@
"id": 23
}
],
"rtcicecandidatetype-enum": [
{
"description": "Add RTCIceCandidate.relayProtocol",
"pr": 2763,
"tests": [
"webrtc/idlharness.https.window.html"
],
"testUpdates": [
"web-platform-tests/wpt#36157"
],
"difftype": "append",
"type": "addition",
"status": "candidate",
"id": 16
}
],
"usernameFragment-desc": [
{
"description": "Add RTCIceCandidate.relayProtocol",
Expand Down Expand Up @@ -335,21 +351,8 @@
],
"addtransceiver-algo": [
{
"description": "TypeError unless all or none of encodings have rids",
"pr": 2774,
"tests": [
"webrtc/RTCRtpParameters-encodings.html"
],
"testUpdates": [
"web-platform-tests/wpt#37477"
],
"type": "correction",
"status": "candidate",
"id": 18
},
{
"description": "TypeError on duplicate rids",
"pr": 2775,
"description": "TypeError unless all or none of encodings have rids and on duplicate rids",
"pr": [2774, 2775],
"tests": [
"webrtc/RTCRtpParameters-encodings.html"
],
Expand Down Expand Up @@ -398,6 +401,19 @@
"type": "correction",
"status": "candidate",
"id": 24
},
{
"description": "Add codec to RTCRtpEncodingParameters",
"type": "addition",
"status": "candidate",
"id": 49,
"pr": 2985,
"tests": [
"webrtc/RTCRtpParameters-codec.html"
],
"testUpdates": [
"web-platform-tests/wpt#47663"
]
}
],
"setparameters-algo": [
Expand Down Expand Up @@ -460,6 +476,19 @@
"type": "correction",
"status": "candidate",
"id": 32
},
{
"description": "Add codec to RTCRtpEncodingParameters",
"type": "addition",
"status": "candidate",
"id": 49,
"pr": 2985,
"tests": [
"webrtc/RTCRtpParameters-codec.html"
],
"testUpdates": [
"web-platform-tests/wpt#47663"
]
}
],
"create-sender-algo": [
Expand Down Expand Up @@ -664,7 +693,7 @@
"description": "Create RTCRtpCodec dictionary and reuse in RTCRtpCodecCapability and RTCRtpCodecParameters definitions",
"pr": 2834,
"testUpdates": "not-testable",
"type": "modify",
"type": "correction",
"status": "candidate",
"id": 29
}
Expand Down Expand Up @@ -937,11 +966,27 @@
],
"rtcrtpencodingparamters-attributes-active": [
{
"description": "Add codec to RTCRtpEncodingParameters, moved from webrtc-extensions",
"description": "Add codec to RTCRtpEncodingParameters",
"type": "addition",
"status": "candidate",
"difftype": "append",
"id": 49,
"pr": 2985,
"tests": [
"webrtc/RTCRtpParameters-codec.html"
],
"testUpdates": [
"web-platform-tests/wpt#47663"
]
}
],
"stable-signaling-1": [
{
"description": "Add codec to RTCRtpEncodingParameters",
"type": "addition",
"status": "candidate",
"difftype": "append",
"id": 47,
"id": 49,
"pr": 2985,
"tests": [
"webrtc/RTCRtpParameters-codec.html"
Expand Down
2 changes: 1 addition & 1 deletion base-rec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3396,7 +3396,7 @@ <h5 id="x4-4-1-5-set-the-session-description"><bdi class="secno">4.4.1.5 </bdi>
steps:
</p>
<ol>
<li>
<li id="stable-signaling-1">
<p class="needs-test">
For any <var>transceiver</var> that was removed
from the <a data-link-type="dfn" href="#transceivers-set" class="internalDFN" id="ref-for-transceivers-set-11">set of transceivers</a> in a previous
Expand Down
8 changes: 4 additions & 4 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2796,7 +2796,7 @@ <h4>
steps:
</p>
<ol>
<li>
<li id="stable-signaling-1">
<p class="needs-test">
For any <var>transceiver</var> that was removed
from the [= set of transceivers =] in a previous
Expand All @@ -2811,7 +2811,7 @@ <h4>
firing on these objects in a queued task.
</p>
</li>
<li>
<li class="add-to-stable-signaling-1">
<p>For each <var>transceiver</var> in <var>connection</var>'s [= set of transceivers =]:</p>
<ol>
<li>
Expand Down Expand Up @@ -6565,7 +6565,7 @@ <h4>
{{RTCIceTcpCandidateType/active}} ICE TCP candidates.
</p>
</section>
<section>
<section id="rtcicecandidatetype-enum">
<h4>
<dfn>RTCIceCandidateType</dfn> Enum
</h4>
Expand Down Expand Up @@ -6629,7 +6629,7 @@ <h4>
</table>
</div>
</section>
<section>
<section class="add-to-rtcicecandidatetype-enum">
<h4>
<dfn>RTCIceServerTransportProtocol</dfn> Enum
</h4>
Expand Down
Loading