Fix descriptions according to the upgraded draft #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove description reference to non-existing-field totalSamplesDecoded
|
dontcallmedom marked as non substantive for IPR from ash-nazg. |
|
hmmm... we should link to |
|
no other mechanism at this stage, since provisional stats aren't indexed in our definition db at this time. |
henbos
approved these changes
Oct 4, 2022
alvestrand
reviewed
Oct 4, 2022
| @@ -1238,7 +1238,7 @@ <h2> | |||
| This metric is not incremented for frames that are not decoded, | |||
| i.e. {{RTCReceivedRtpStreamStats/framesDropped}}. | |||
| The average processing delay can be calculated by dividing the {{totalProcessingDelay}} with the | |||
| {{framesDecoded}} for video (or povisional stats spec <code>totalSamplesDecoded</code> for audio). | |||
| {{framesDecoded}} for video. | |||
There was a problem hiding this comment.
"For video" should be at the start of the paragraph.
henbos
requested changes
Oct 4, 2022
|
Perhaps a better solution would be to caveat this metric for video, ergo adding a preamble that it is only for video. |
|
The issue #660 is about marking up the stats that are only implemented for one stat. |
|
Let's follow up in #660 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff