Editorial: Clarify ::cue(*) and ::cue(:root) and WebVTT Leaf Node Objects #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
danae404 marked as non substantive for IPR from ash-nazg. |
danae404
requested review from
aphillips,
foolip,
gkatsev and
silviapfeiffer
gkatsev
reviewed
Sep 12, 2025
| </pre> | ||
| </td> | ||
| <td class=long> | ||
| <p><a>WebVTT Internal Node Objects</a> (except the root <a>list of WebVTT Node Objects</a>) |
There was a problem hiding this comment.
should the except the root parenthetical be removed from the class selector example below (line 5099) as well?
There was a problem hiding this comment.
I dont think you can assign a class to plain text in the cue; you have to encompass the text in a <c> to give it a class. So keeping the parenthesis still makes sense.
index.bs
Outdated
|
|
||
| </dl> | ||
|
|
||
| <br> |
There was a problem hiding this comment.
I don't like br being used for spacing purposes. Can we use CSS instead? dl + p { margin-top: 2em }
index.bs
Outdated
Comment on lines
5432
to
5435
| empty string. Note that the <a>universal selector</a> matches all <a>WebVTT Internal Node Objects</a>, including the | ||
| root <a>list of WebVTT Node Objects</a>.</p></li> | ||
|
|
||
| <li><p>''::cue(:root)'' is equivalent to ''::cue''.</p></li> |
There was a problem hiding this comment.
May be better to make these two as a <p class=note> to keep this change editorial, since notes are non-normative.
…ng around the WebVTT Leaf Nodes section so that it does not get confused to be subclass of WebVTT Internal Nodes
danae404
force-pushed
the
selector-clarifications
branch
from
46e5068 to
898f395
Compare
zcorpan
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #533
Add notes and examples to clarify that
::cue(*)matches all WebVTT internal node objects, including the root list of WebVTT node objects, and to clarify that::cue(:root)is a valid selector and it matches the same elements as::cue.Because a universal selector is within the class of type selectors, delete the parenthical note in Example 22 that makes it seem that type selectors can never match the root.
Also add spacing around the section of Leaf Node Objects. The current spacing makes it easy to confuse it as a subclass of WebVTT Internal Node Objects.
Preview | Diff