Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MapName to GamesPlayedOnMap #352

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CoffMakesThings
Copy link

Data in various collections is stored based on the map's "Map" value, which is derived from the filename. We can retrieve a mapping from the map file name to the actual map name based on the active maps stored in the matchmaking service. But that only helps us for this season.

Matches map filter for this season, using mapping from matchmaking service
image

Matches map filter for season 19, no mapping can be done easily
image

This issue also affects the matchup statistics, when the maps played are from older seasons.

image

Looking at the DB dumps, it seems that the proper map name has usually been provided in MatchFinishedEvent documents, under match.mapName. I propose this temporary handler, which will go through all historical MatchFinishedEvent documents and provide a mapName on GamesPerSeason objects in the MapsPerSeasonCollection. The temporary handler could then be deleted, as MapsPerSeasonHandler would store map names from now on.

Before the new handler is run
Screenshot 2024-10-31 002827

After the handler is run
Screenshot 2024-10-31 004356

This will enable us to provide a list of the map names in each season, for match filters. It will also allow us to provide a mapping of file name -> actual map name for each season, to help present data stored in other collections such as the matchup per map statistics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant