Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't see some matches details still #354

Closed
Miezhiko opened this issue Jan 31, 2021 · 7 comments
Closed

Can't see some matches details still #354

Miezhiko opened this issue Jan 31, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@Miezhiko
Copy link

https://www.w3champions.com/match/601586d47e9f54f8aa0be2fc - because of name spoofing
(suggestion solution - show player names as is on score screen for this case, avoid undefined error)

https://www.w3champions.com/match/6015cfb77e9f54f8aa1f6d47 - no idea why

@jj-apps

related #328

@joleb
Copy link
Contributor

joleb commented Feb 1, 2021

As a workaround I'd suggest we should implement a default error handler if something like this happens.
like: "uh this didn't work as expected, we are working on that." - everything is better than a blank page :D

@Miezhiko
Copy link
Author

Miezhiko commented Feb 2, 2021

at least that but I'd prefer if website will display match details still

@modmoto
Copy link
Member

modmoto commented Feb 2, 2021

Yes definitely,should not be all to hard aswell, the error occurs because of a [0] on the wrong location.

@Cepheid-UK Cepheid-UK added the bug Something isn't working label Feb 10, 2021
@joleb
Copy link
Contributor

joleb commented Feb 13, 2021

i will take a look at this :)

@joleb
Copy link
Contributor

joleb commented Apr 13, 2021

if no one is willing to check my pr, i'll close it soon, just fyi. merging the current master branch is kinda waste for me, if its not used anyways.

@modmoto
Copy link
Member

modmoto commented Apr 14, 2021

you mean #363?

@Cepheid-UK
Copy link
Member

if no one is willing to check my pr, i'll close it soon, just fyi. merging the current master branch is kinda waste for me, if its not used anyways.

Hey sorry man, we just have a lot to juggle. Ty for the PR.

Cepheid-UK added a commit that referenced this issue May 5, 2021
adding fallback values, if scores not loaded properly #354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants