Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadart Milestone 4 #1138

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Polkadart Milestone 4 #1138

merged 3 commits into from
Mar 8, 2024

Conversation

leonardocustodio
Copy link
Contributor

@leonardocustodio leonardocustodio commented Feb 23, 2024

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2004

@leonardocustodio leonardocustodio changed the title Polkadart Milestone 4 delivery Polkadart Milestone Feb 23, 2024
@leonardocustodio leonardocustodio changed the title Polkadart Milestone Polkadart Milestone 4 Feb 23, 2024
@justkawal
Copy link

🎉 🎉

@semuelle
Copy link
Member

semuelle commented Feb 29, 2024

Sorry for the wait, @leonardocustodio. @dsm-w3f will look into it soon.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Feb 29, 2024

Thanks @semuelle I'll take a look at this evaluation.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Mar 1, 2024

@leonardocustodio thank you for the milestone delivery. Please take a look at the evaluation document in this pull request and provide proper answers and fixes. Let me know when I can continue this evaluation.

@justkawal
Copy link

justkawal commented Mar 1, 2024

@leonardocustodio thank you for the milestone delivery. Please take a look at the evaluation document in this pull request and provide proper answers and fixes. Let me know when I can continue this evaluation.

Hey @dsm-w3f Sorry for the trouble, the fixes are now done and is ready to be tested again.

@justkawal
Copy link

justkawal commented Mar 2, 2024

@dsm-w3f
Also on the sr25519:
We think writing in pure dart code was a good choice although it took intensive testing and hours.

  • Writing in pure dart makes it easy to maintain codebase with lesser dependencies.
  • Bridging rust to flutter still lacks supports for some parts of intermediate code generation.
  • Good amount of refactoring would be needed to align current code with async native calls.
  • With code written in pure dart, it enables to cover all the platforms and provide fixes without depending on 3rd parties.

@justkawal
Copy link

@dsm-w3f
For the docker: surprisingly it worked on my side, I guess it’s a low memory issue maybe.
Can you try, giving higher swap and memory in docker-settings -> resources….

Thanks for your time.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Mar 4, 2024

@justkawal thank you for the answers and fixes. I updated the evaluation document. I'm still having problems to run the metadata automated tests. Could you please inform what is the configuration of the machine that you was able to run this tests? Please see more details in the evaluation document in this PR.

@justkawal
Copy link

justkawal commented Mar 4, 2024

in this PR

Hey @dsm-w3f,

Seed (Dev-Phrase): bottom drive obey lake curtain smoke basket hold race lonely fit walk

Derivation paths for signatories are: //TeslaS1, //TeslaS2, //TeslaS3
Derivation paths for receiver account: //TeslaR

So in the latest update to main branch, I had mentioned the seed (dev-phrase) in the comment in the file multisig_example.dart: (3 days ago) https://github.com/leonardocustodio/polkadart/blob/020eae9fae70e71f838eb94623b43993de223b19/packages/polkadart/example/multisig_example.dart#L8

Also as I can see in the issue image of multisig_example.dart at line 26, So now in the updated code, line 26 is having comment and not any code.
Here: https://github.com/leonardocustodio/polkadart/blob/020eae9fae70e71f838eb94623b43993de223b19/packages/polkadart/example/multisig_example.dart#L26

So, It seems that main is not up-to-date, Please can you do a git pull again from the main branch again or a fresh clone maybe?

Thank you so much for your time.

@justkawal
Copy link

justkawal commented Mar 4, 2024

@dsm-w3f
Also to test and run the multisig example, we don't need polkadart_cli as we're not using it in that respective example.
So, to run and test multisig_example.dart, you can just run dart pub get inside that package and then run that multisig_example.dart file.

For the issue in examples: To add polkadart_cli and polkadart in pubspec.yaml
I guess I already fixed that previous week: https://github.com/leonardocustodio/polkadart/blob/020eae9fae70e71f838eb94623b43993de223b19/examples/pubspec.yaml#L30

So, maybe just needs a git pull, or a fresh clone.

Thank you so much. ❤️

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Mar 5, 2024

@justkawal thank you for the answer. Now it worked for me. The evaluation document was updated in this PR. It would be nice to have these instructions added to the documentation. The only point that is still pending in this evaluation is the memory problem while running the automated tests. Please let me know when I can continue this evaluation.

@justkawal
Copy link

justkawal commented Mar 5, 2024

@dsm-w3f
Sure, I'll have a look into the memory thing today. Sorry about that.

Either way, can you try? with:

dart pub global activate melos

melos test

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Mar 5, 2024

@justkawal I tried these commands and the behavior was the same as running using docker. The memory is consumed until get all memory from the machine.

@justkawal
Copy link

@dsm-w3f
Thanks for the timely feedback.
I will try something to lower the memory usage.

@justkawal
Copy link

justkawal commented Mar 5, 2024

@dsm-w3f
Can you do a pull and try again?
I tested it on a lower memory system now and it seems to be working fine.

Note: (It might take some time to build around (8-9 mins))

Thank you.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Mar 6, 2024

@justkawal thank you for the improvements and fixes. It worked now. I updated the evaluation document in this PR. Great job! @semuelle this evaluation is accepted by my side and the evaluation PR is open.

@justkawal
Copy link

@dsm-w3f @semuelle
Thank you so much for your time team.
💯🎉

@leonardocustodio
Copy link
Contributor Author

I'm just filling the form, all milestones we have received as USDC-ERC20, isn't that possible anymore? We must always used AssetHub now?

@keeganquigley
Copy link
Contributor

Hi @leonardocustodio yes that's correct, our payment options changed recently and we no longer offer ETH mainnet payments. Does this work for you?

@leonardocustodio
Copy link
Contributor Author

Ok @keeganquigley , I've submitted the invoice with the new address and also sent a PR amending the application with the new address: w3f/Grants-Program#2245

@keeganquigley
Copy link
Contributor

Thanks @leonardocustodio much appreciated, your milestone evaluation has been passed but I will wait for the amendment to be approved before merging the delivery to avoid any confusion. Congrats on finishing the grant!

@semuelle
Copy link
Member

semuelle commented Mar 8, 2024

Amendment and evaluation are merged, milestone is accepted. Congrats, @leonardocustodio.

@semuelle semuelle merged commit 21193d2 into w3f:master Mar 8, 2024
6 checks passed
Copy link

github-actions bot commented Mar 8, 2024

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

github-actions bot commented Mar 8, 2024

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@leonardocustodio
Copy link
Contributor Author

Thanks guys, exicited to see all new flutter apps to come to polkador usong flutter 😁

Filled the invoice and hopefully I can think of another project that can be beneficial for everybody soon

@RouvenP
Copy link

RouvenP commented Mar 15, 2024

hi @leonardocustodio we sent the payment today

@leonardocustodio
Copy link
Contributor Author

Hello @RouvenP , received, thank you very much, hope to work with you guys again soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants