Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy Evaluation Milestone 1 #851

Merged
merged 7 commits into from
May 17, 2023
Merged

Galaxy Evaluation Milestone 1 #851

merged 7 commits into from
May 17, 2023

Conversation

Ali-Usama
Copy link
Contributor

External Evaluation Galaxy

The delivery is satisfactory and as per the application. However, some suggestions are mentioned in the evaluation and after that, it'll be considered as accepted.

Link to the application pull request: Galaxy

@Ali-Usama Ali-Usama mentioned this pull request May 2, 2023
5 tasks
@7flash
Copy link
Contributor

7flash commented May 3, 2023

External Evaluation Galaxy

The delivery is satisfactory and as per the application. However, some suggestions are mentioned in the evaluation and after that, it'll be considered as accepted.

Link to the application pull request: Galaxy

Updated. Ready for evaluation.

@Ali-Usama
Copy link
Contributor Author

Thanks for the quick fixes, @7flash. I've updated my evaluation as well.

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the evaluation, @Ali-Usama. I had some questions about the delivery, so I'll wait for those to be resolved to merge this one.

I also made some change suggestions to your evaluation sheet. Generally, we prefer to link to a specific version of a file or directory in these, because HEAD versions might change and not reflect what was reviewed in the future.

evaluations/galaxy_1_ali-usama.md Outdated Show resolved Hide resolved
evaluations/galaxy_1_ali-usama.md Outdated Show resolved Hide resolved
evaluations/galaxy_1_ali-usama.md Outdated Show resolved Hide resolved
evaluations/galaxy_1_ali-usama.md Outdated Show resolved Hide resolved
@semuelle semuelle merged commit dce949c into w3f:master May 17, 2023
@7flash
Copy link
Contributor

7flash commented May 17, 2023

Thanks @semuelle @Ali-Usama @keeganquigley @randombishop

Comments and questions received from you are highly appreciated, your well-written feedback continuously pushing project forwards, - thank you!

@RouvenP
Copy link

RouvenP commented Jun 2, 2023

hi @Ali-Usama we transferred the KSM yesterday

@Ali-Usama Ali-Usama deleted the galaxy-eval branch June 2, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants