Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application for MoveVM Substrate Pallet, part 2 #1902

Merged
merged 9 commits into from
Sep 1, 2023
Merged

Application for MoveVM Substrate Pallet, part 2 #1902

merged 9 commits into from
Sep 1, 2023

Conversation

MeerKatDev
Copy link
Contributor

Project Abstract

This application is a response to Move Smart Contract Pallet RFP and a follow-up to our previous work on the RFP. The deliverables were submitted with this PR.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@MeerKatDev MeerKatDev changed the title Application for Substrate Move System Pallet, pt. 2 Application for Substrate Move System Pallet, part 2 Aug 10, 2023
@MeerKatDev MeerKatDev changed the title Application for Substrate Move System Pallet, part 2 Application for MoveVM Substrate Pallet, part 2 Aug 10, 2023
Noc2
Noc2 requested changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. One quick feedback from the airport: The formatting of the milestone table seems to be off. Could you fix this?

@MeerKatDev
Copy link
Contributor Author

Thanks for the application. One quick feedback from the airport: The formatting of the milestone table seems to be off. Could you fix this?

Thanks for noticing, yeah there were some pesky newlines. Fixed!

@nikw3f
Copy link
Contributor

nikw3f commented Aug 14, 2023

total_milestones is missing as well

Noc2
Noc2 requested changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here. I'm happy to mark the application as ready for review. Would you be willing to reduce the price? If I take your previous grant application as a reference, this one would cost 96k ;-) Apart from this, it would be nice if we could finance the final milestone either together with some parachain teams that are willing to potentially integrate the pallet or ask the community via the treasury to support it.

@Noc2 Noc2 added the ready for review The project is ready to be reviewed by the committee members. label Aug 24, 2023
@semuelle semuelle self-assigned this Aug 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MeerKatDev
Copy link
Contributor Author

MeerKatDev commented Aug 24, 2023 •
edited
Loading

Sorry for the delay here. I'm happy to mark the application as ready for review. Would you be willing to reduce the price? If I take your previous grant application as a reference, this one would cost 96k ;-) Apart from this, it would be nice if we could finance the final milestone either together with some parachain teams that are willing to potentially integrate the pallet or ask the community via the treasury to support it.

Hi sorry @Noc2, my mistake! Should be good now :D

Not sure what to do with the CLA assistant?

Noc2
Noc2 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Regarding the CLA, @semuelle recently added a new tool. It should be fine for now.

@nikw3f nikw3f requested review from niklabh and removed request for niklabh August 24, 2023 17:37
niklabh

This comment was marked as off-topic.

Sign in to view

@semuelle
Copy link
Member

Sorry for the confusion, @MeerKatDev. I have updated the instructions for the CLA bot. Could you submit the text between the horizontal lines as a comment here, as a way of signing the CLA? Cheers!

@MeerKatDev
Copy link
Contributor Author

I have read and hereby sign the Contributor License Agreement.

@Noc2 Noc2 merged commit 1bfa40e into w3f:master Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions.

Before you start, take a moment to read through our announcement guidelines for all communications related to the grant or make them known to the right person in your organisation. In particular, please don't announce the grant publicly before at least the first milestone of your project has been approved. At that point or shortly before, you can get in touch with us at [email protected] and we'll be happy to collaborate on an announcement about the work you’re doing.

Lastly, please remember to let us know in case you run into any delays or deviate from the deliverables in your application. You can either leave a comment here or directly request to amend your application via PR. We wish you luck with your project! 🚀

@keeganquigley
Copy link
Contributor

Hi @MeerKatDev just checking in, how is progress coming along?

@MeerKatDev MeerKatDev mentioned this pull request Feb 8, 2024
Merged
5 tasks
@MeerKatDev
Copy link
Contributor Author

Hi @MeerKatDev just checking in, how is progress coming along?

Hi @keeganquigley , great timing! We have just submitted the deliverables 👍

@Rqnsom Rqnsom mentioned this pull request Feb 26, 2024
Closed
11 tasks
taqtiqa-mark pushed a commit to taqtiqa-mark/Grants-Program that referenced this pull request Jun 6, 2024
@MeerKatDev
Application for MoveVM Substrate Pallet, part 2 (w3f#1902)
cd920c3 
* changing starting date for substrate move pallet part 1

* added part 2 of movevm substrate grant

* added starting date

* Add MoveVM Substrate Pallet part 2 proposal

* changed starting date

* fixed table's newline

* updates to the application

* Update Substrate_Move_System_Pallet_2.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklabh niklabh niklabh requested changes

@nikw3f nikw3f nikw3f approved these changes

@dsm-w3f dsm-w3f dsm-w3f approved these changes

@BenWhiteJam BenWhiteJam BenWhiteJam approved these changes

@Noc2 Noc2 Noc2 approved these changes

@laboon laboon laboon approved these changes

Assignees

@semuelle semuelle

Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@MeerKatDev @nikw3f @semuelle @keeganquigley @niklabh @laboon @Noc2 @BenWhiteJam @dsm-w3f