Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking Rewards - Research Methodology Development - Milestone 1 #2484

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Romao08
Copy link

@Romao08 Romao08 commented Jan 14, 2025

Project Abstract

This proposal aims to enhance Polkadot’s ecosystem by delivering advanced staking tools, starting with the development of a data-driven framework to rank validators, and amplifying visibility through targeted marketing efforts. By leveraging Staking Rewards’ platform with over 150,000 monthly users, we seek to boost staking adoption and engagement within Polkadot’s community, beginning with the first milestone to develop a comprehensive validator ranking methodology.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (Polkadot AssetHub (USDC & DOT) address in the application and bank details via email, if applicable).
  • I understand that an agreed upon percentage of each milestone will be paid in vested DOT, to the Polkadot address listed in the application.
  • I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Noc2 Noc2 self-assigned this Jan 15, 2025
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. Could you improve the formatting of the PR? See the application template at https://github.com/w3f/Grants-Program/blob/master/applications/application-template.md. Or, better yet, use the research template at https://github.com/w3f/Grants-Program/blob/master/applications/application-template-research.md. Let us know if you have any questions.

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Jan 15, 2025
Copy link
Author

@Romao08 Romao08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format of the document is improved.
Please let me know if there is something needed to be done.

Thanks

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the proposal. It looks much better now, but it would be highly appreciated if you could simply use the formatting of one of your default templates above. All of our internal logic (e.g. github actions) and review process is optimised for this. The total amount of the grant should also be 15k and not 100k.

Copy link
Author

@Romao08 Romao08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format of the document is updated from Template.
Please let me know if everything is ok.

Thanks

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the update. One last comment regarding the formatting: Could you integrate the deliverables and the milestone in the Development Roadmap section similar to the template, https://github.com/w3f/Grants-Program/blob/master/applications/application-template.md#milestone-1-example--basic-functionality A table would be pretty useful.

Copy link
Author

@Romao08 Romao08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Let me know if the Table format looks good to you

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went ahead and created a PR to your repo to fix it. I have one additional question: Would you be willing to be paid in USDC on Assethub. This might make things easier for us.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Jan 23, 2025
@Romao08
Copy link
Author

Romao08 commented Jan 23, 2025

Thanks for helping! Yes, can do usdc payments.

applications/staking_rewards.md Outdated Show resolved Hide resolved
applications/staking_rewards.md Outdated Show resolved Hide resolved
@Romao08
Copy link
Author

Romao08 commented Jan 29, 2025

Done! Thanks

@keeganquigley
Copy link
Contributor

Thanks @Romao08 are you also willing to accept 50% of payment in vested DOT? The DOT is vested linearly on-chain for two years, see here for details. If this works for you please mark 50% DOT under Total Costs, as is shown in the template. Thanks!

@Romao08
Copy link
Author

Romao08 commented Jan 29, 2025

Yes, it works for us. Just added to the proposal that 50% of payment can be vested in dot isntead 100% FIAT.
Please let me know if everything is correct

keeganquigley
keeganquigley previously approved these changes Jan 29, 2025
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Romao08 much appreciated. I'm personally willing to support it.

Noc2
Noc2 previously approved these changes Jan 31, 2025
@keeganquigley
Copy link
Contributor

@Romao08 can you also please complete the KYC verification process? Thanks!

@Romao08
Copy link
Author

Romao08 commented Feb 1, 2025

It's done.
Thanks!

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application, @Romao08. Happy to support it, I just have a few requests, see below. Also, could you add a license, e.g. CC BY-SA 4.0? for all publications to the spec? Lastly, both @Romao08 and @antonio need to still sign the CLA.

**Deliverables for Milestone 1:**
| Number | Deliverable | Specification |
| ------- | ----------------- | ------------------------------------------------------------------------------------------------------------ |
| 0. | Article | We will publish an **article**/workshop that explains [...] (what was done/achieved as part of the grant). (Content, language, and medium should reflect your target audience described above.) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the specification to match your goals.

| 2. | Data Sources | Analysis of on-chain and off-chain data sources. |
| 3. | Validator Scoring | Preliminary scoring model for ranking validators based on weighted metrics. |
| 4. | DN Selection | A ranked list of the **Top 16 Decentralized Nodes (DNs)** for inclusion in the Default Nomination Pool. |
| 5. | Research Report | Results will be published in the form of a **Research Report**. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this different from deliverable 0? If not, please remove either one.

@Romao08
Copy link
Author

Romao08 commented Feb 3, 2025

recheck

@Romao08
Copy link
Author

Romao08 commented Feb 3, 2025

I have read and hereby sign the Contributor License Agreement.

@Romao08
Copy link
Author

Romao08 commented Feb 3, 2025

recheck

@Romao08 Romao08 dismissed stale reviews from Noc2 and keeganquigley via f6821a2 February 3, 2025 15:22
@Romao08
Copy link
Author

Romao08 commented Feb 3, 2025

The file is updated. Please let me know if everything looks correct now.
Thanks!

@keeganquigley
Copy link
Contributor

Thanks @Romao08 could you also please complete KYB verification for Finrate AG? Alternatively, if you don't have a legal registered entity, we would ask that the rest of the team perform a KYC check as well. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin-review This application requires a review from an admin. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants