Corner cases about (child) storage

adapters/substrate/src/host_api/child_storage.rs

@@ -44,6 +44,37 @@ pub fn ext_default_child_storage_get_version_1(rtm: Runtime, input: ParsedInput)
     ext_default_child_storage_set_version_1(rtm, input)
 }
 
+pub fn ext_default_child_storage_set_version_1_invalid_child_key(mut rtm: Runtime, input: ParsedInput) {
+    // Parse inputs
+    let child_key = input.get(0);
+    // Skipping index `1`
+    let key = input.get(2);
+    let value = input.get(3);
+
+    // Set NON-child key/value
+    let _ = rtm.call("rtm_ext_storage_set_version_1", &(key, value).encode());
+
+    // Get NON-child value
+    let res = rtm
+        .call_and_decode::<Option<Vec<u8>>>("rtm_ext_storage_get_version_1", &key.encode())
+        .unwrap();
+    assert_eq!(res, value);
+
+    // Try to get child value from NON-child key
+    let res = rtm.call_and_decode::<Option<Vec<u8>>>(
+        "rtm_ext_default_child_storage_get_version_1",
+        &(key, key).encode(),
+    );
+    assert!(res.is_none());
+
+    // Try to get child value from NON-child key (note that `child_key` does not exist)
+    let res = rtm.call_and_decode::<Option<Vec<u8>>>(
+        "rtm_ext_default_child_storage_get_version_1",
+        &(child_key, key).encode(),
+    );
+    assert!(res.is_none());
+}
+
 pub fn ext_default_child_storage_read_version_1(mut rtm: Runtime, input: ParsedInput) {
     // Parse inputs
     let child_key1 = input.get(0);

adapters/substrate/src/host_api/mod.rs

@@ -79,6 +79,8 @@ pub fn process_subcommand(matches: &ArgMatches) {
             "ext_storage_append_version_1" => storage::ext_storage_append_version_1(rtm, input),
             "ext_storage_root_version_1" => storage::ext_storage_root_version_1(rtm, input),
             "ext_storage_next_key_version_1" => storage::ext_storage_next_key_version_1(rtm, input),
+            "ext_storage_set_version_1_try_fetch_child_key" => storage::ext_storage_set_version_1_try_fetch_child_key(rtm, input),
+            "ext_storage_set_version_1_try_set_child_key" => storage::ext_storage_set_version_1_try_set_child_key(rtm, input),
 
             // child storage api
             "ext_default_child_storage_set_version_1" => {
@@ -87,6 +89,9 @@ pub fn process_subcommand(matches: &ArgMatches) {
             "ext_default_child_storage_get_version_1" => {
                 child_storage::ext_default_child_storage_get_version_1(rtm, input)
             }
+            "ext_default_child_storage_set_version_1_invalid_child_key" => {
+                child_storage::ext_default_child_storage_set_version_1_invalid_child_key(rtm, input)
+            }
             "ext_default_child_storage_read_version_1" => {
                 child_storage::ext_default_child_storage_read_version_1(rtm, input)
             }

adapters/substrate/src/host_api/storage.rs

@@ -282,3 +282,70 @@ pub fn ext_storage_next_key_version_1(mut rtm: Runtime, input: ParsedInput) {
         assert!(res.is_none());
     }
 }
+
+pub fn ext_storage_set_version_1_try_fetch_child_key(mut rtm: Runtime, input: ParsedInput) {
+    // Parse inputs
+    let child_key = input.get(0);
+    // Skipping index `1`
+    let key = input.get(2);
+    let value = input.get(3);
+
+    // Set child key/value
+    let _ = rtm.call(
+        "rtm_ext_default_child_storage_set_version_1",
+        &(child_key, key, value).encode(),
+    );
+
+    // Get child value
+    let res = rtm
+        .call_and_decode::<Option<Vec<u8>>>(
+            "rtm_ext_default_child_storage_get_version_1",
+            &(child_key, key).encode(),
+        )
+        .unwrap();
+    assert_eq!(res, value);
+
+    // Try to get value of child storage key itself (must fail).
+    let res = rtm
+        .call_and_decode::<Option<Vec<u8>>>("rtm_ext_storage_get_version_1", &child_key.encode());
+    assert!(res.is_none());
+
+    // Try to read value of child storage key itself (must fail).
+    let res = rtm.call_and_decode::<Option<Vec<u8>>>(
+        "rtm_ext_storage_read_version_1",
+        &(child_key, 0, value.len() as u32).encode(),
+    );
+    assert!(res.is_none());
+}
+
+pub fn ext_storage_set_version_1_try_set_child_key(mut rtm: Runtime, input: ParsedInput) {
+    // Parse inputs
+    let child_key = input.get(0);
+    // Skipping index `1`
+    let key = input.get(2);
+    let value = input.get(3);
+
+    // Set child key/value
+    let _ = rtm.call(
+        "rtm_ext_default_child_storage_set_version_1",
+        &(child_key, key, value).encode(),
+    );
+
+    // Set NON-child key/value with identitcal key (DROPPED)
+    let _ = rtm.call("rtm_ext_storage_set_version_1", &(child_key, vec![1]).encode());
+
+    // Try to get (dropped) value.
+    let res = rtm
+        .call_and_decode::<Option<Vec<u8>>>("rtm_ext_storage_get_version_1", &child_key.encode());
+    assert!(res.is_none());
+
+    // Get child value (must not be destroyed)
+    let res = rtm
+        .call_and_decode::<Option<Vec<u8>>>(
+            "rtm_ext_default_child_storage_get_version_1",
+            &(child_key, key).encode(),
+        )
+        .unwrap();
+
+    assert_eq!(res, value);
+}

fixtures/host-api/HostApiFunctions.jl

@@ -28,8 +28,11 @@ module HostApiFunctions
 	const child_key_value = [
 		"ext_default_child_storage_set_version_1",
 		"ext_default_child_storage_get_version_1",
+		"ext_default_child_storage_set_version_1_invalid_child_key",
 		"ext_default_child_storage_clear_version_1",
-		"ext_default_child_storage_exists_version_1"
+		"ext_default_child_storage_exists_version_1",
+		"ext_storage_set_version_1_try_fetch_child_key",
+		"ext_storage_set_version_1_try_set_child_key"
 	]
 
 	const child_prefix_key_value_key_value = [

fixtures/host-api/HostApiOutputs.jl

@@ -189,6 +189,17 @@ module HostApiOutputs
         "value-added\n",
         "Reactive\n",
         "secondary\n",
+        # ext_default_child_storage_set_version_1_invalid_child_key
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
         # ext_default_child_storage_clear_version_1
         nothing,
         nothing,
@@ -211,6 +222,28 @@ module HostApiOutputs
         "true\n",
         "true\n",
         "true\n",
+        # ext_storage_set_version_1_try_fetch_child_key
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        # ext_storage_set_version_1_try_set_child_key
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
+        nothing,
     ]
 
     const child_prefix_key_value_key_value = [