Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unbonding Period Explanation #5322

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Add Unbonding Period Explanation #5322

merged 9 commits into from
Oct 31, 2023

Conversation

filippoweb3
Copy link
Contributor

No description provided.

@filippoweb3 filippoweb3 added the A2 - Please Review Pull request is ready for review. label Oct 30, 2023
@filippoweb3 filippoweb3 self-assigned this Oct 30, 2023
@filippoweb3 filippoweb3 requested a review from DrW3RK October 30, 2023 11:00
@filippoweb3 filippoweb3 linked an issue Oct 30, 2023 that may be closed by this pull request
Add explanation for unbonding period #5319
Closed
DrW3RK
DrW3RK requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@DrW3RK DrW3RK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bonding duration is in eras, not days. So, the kusama guide rendering is incorrect. You will need to implement an eras to days function, before rendering the value.

image

@DrW3RK DrW3RK added A3 - Changes Requested Pull Request needs to be updated. and removed A2 - Please Review Pull request is ready for review. labels Oct 30, 2023
@filippoweb3
Copy link
Contributor Author

@DrW3RK I added a new erasToDays filter. It should be fixed now.

@filippoweb3 filippoweb3 requested a review from DrW3RK October 31, 2023 12:00
@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A3 - Changes Requested Pull Request needs to be updated. labels Oct 31, 2023
DrW3RK
DrW3RK reviewed Oct 31, 2023
View reviewed changes
DrW3RK
DrW3RK approved these changes Oct 31, 2023
View reviewed changes
@filippoweb3 filippoweb3 merged commit 92a4cb5 into master Oct 31, 2023
@filippoweb3 filippoweb3 deleted the unbonding-period-info branch October 31, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrW3RK DrW3RK DrW3RK approved these changes

@AlistairStewart AlistairStewart Awaiting requested review from AlistairStewart

Assignees

@filippoweb3 filippoweb3

Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add explanation for unbonding period
3 participants
@filippoweb3 @AlistairStewart @DrW3RK