-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Polimec HRMP info #5503
Add Polimec HRMP info #5503
Conversation
docs/build/build-hrmp-channels.md
Outdated
The xcm-executor pallet can be forked by parachains' teams and modified to include logic to handle | ||
[high-level HRMP instructions](https://paritytech.github.io/xcm-docs/journey/channels-and-bridges.html#hrmpnewchannelopenrequest). | ||
These instructions are not included in the default version of the pallet, but can be used for | ||
opening, accepting, and closing channels without relying on governance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this document gives concrete instructions on how to open HRMP channels between chains, this section falls short explaining what specific logic needs to be added to xcm-executor pallet to handle high-level HRMP instructions. Perhaps, a link to the forked code base and an actual project example that successfully opened channels without relying on governance would help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suggestion came from my comments. We're open-sourcing the code at Polimec next Monday and could include it here. However, the codebase is still in development.
The wording is very good @ filippoweb3. It should be noted that the initial opening would probably not be done by a notification from the relay, since someone needs to send the hrmpInitOpenChannel
extrinsic to the relay first for this to happen.
At Polimec we expect the other parachain to first initiate the opening from whatever means they want (probably sudo), and from this notification start our logic to check if we should accept and initiate the other direction channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Yeah, just want to ensure there are concrete instructions on this page and avoid ambiguity for parachain teams. Sorry for the mix-up with Referenda 340. We will link to your implementation once it is available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuaniRios thanks, we will leave this open until we can link to the instructions you will opensource :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filippoweb3 @DrW3RK Sorry for the delay. We're open sourcing sometime this week, prob tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filippoweb3 our legal team is now reviewing the licences. ETA around Wednesday next week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our codebase is now open source!
Here are some interesting links you might want to use:
- polimec-node repo
- hrmp instruction implementation in xcm-executor fork
- impl of the new xcm-executor config types
Let me know if you have any questions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DrW3RK I added those links above, lmk if its ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @JuaniRios for contributing!
Co-authored-by: joe petrowski <[email protected]>
Co-authored-by: joe petrowski <[email protected]>
Co-authored-by: joe petrowski <[email protected]>
No description provided.