Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polimec HRMP info #5503

Merged
merged 9 commits into from
Jan 26, 2024
Merged

Add Polimec HRMP info #5503

merged 9 commits into from
Jan 26, 2024

Conversation

filippoweb3
Copy link
Contributor

No description provided.

@filippoweb3 filippoweb3 self-assigned this Jan 12, 2024
@filippoweb3 filippoweb3 changed the title Add Polimec info Add Polimec HRMP info Jan 12, 2024
Comment on lines 38 to 41
The xcm-executor pallet can be forked by parachains' teams and modified to include logic to handle
[high-level HRMP instructions](https://paritytech.github.io/xcm-docs/journey/channels-and-bridges.html#hrmpnewchannelopenrequest).
These instructions are not included in the default version of the pallet, but can be used for
opening, accepting, and closing channels without relying on governance.
Copy link
Member

@DrW3RK DrW3RK Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this document gives concrete instructions on how to open HRMP channels between chains, this section falls short explaining what specific logic needs to be added to xcm-executor pallet to handle high-level HRMP instructions. Perhaps, a link to the forked code base and an actual project example that successfully opened channels without relying on governance would help.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion came from my comments. We're open-sourcing the code at Polimec next Monday and could include it here. However, the codebase is still in development.

The wording is very good @ filippoweb3. It should be noted that the initial opening would probably not be done by a notification from the relay, since someone needs to send the hrmpInitOpenChannel extrinsic to the relay first for this to happen.

At Polimec we expect the other parachain to first initiate the opening from whatever means they want (probably sudo), and from this notification start our logic to check if we should accept and initiate the other direction channel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Yeah, just want to ensure there are concrete instructions on this page and avoid ambiguity for parachain teams. Sorry for the mix-up with Referenda 340. We will link to your implementation once it is available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuaniRios thanks, we will leave this open until we can link to the instructions you will opensource :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filippoweb3 @DrW3RK Sorry for the delay. We're open sourcing sometime this week, prob tomorrow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filippoweb3 our legal team is now reviewing the licences. ETA around Wednesday next week

Copy link

@JuaniRios JuaniRios Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our codebase is now open source!
Here are some interesting links you might want to use:

Let me know if you have any questions :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DrW3RK I added those links above, lmk if its ok

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JuaniRios for contributing!

@filippoweb3 filippoweb3 added the A0 - Do Not Merge Pull request should not yet be merged. label Jan 12, 2024
@filippoweb3 filippoweb3 linked an issue Jan 15, 2024 that may be closed by this pull request
@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A0 - Do Not Merge Pull request should not yet be merged. labels Jan 24, 2024
docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
docs/general/thousand-validators.md Outdated Show resolved Hide resolved
docs/general/community.md Show resolved Hide resolved
docs/learn/learn-guides-accounts-multisig.md Outdated Show resolved Hide resolved
docs/learn/learn-guides-accounts-multisig.md Outdated Show resolved Hide resolved
@DrW3RK DrW3RK merged commit e437615 into master Jan 26, 2024
3 checks passed
@DrW3RK DrW3RK deleted the update-hrmp-info branch January 26, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HRMP documentation
4 participants