-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine OpenGov doc #5513
Merged
Merged
Refine OpenGov doc #5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DrW3RK
commented
Jan 15, 2024
•
edited
Loading
edited
- Remove ambiguity on Approval computation
- Move conviction voting section above approval/support section (as calculation example requires understanding of it)
- Add a simple example computing approval and support
DrW3RK
added
A2 - Please Review
Pull request is ready for review.
and removed
A1 - In Progress
Not ready for review yet.
labels
Jan 17, 2024
filippoweb3
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some suggestions. Additionally, I would present the example with bullet points. It eases the read.
Co-authored-by: Filippo <[email protected]>
Co-authored-by: Filippo <[email protected]>
Co-authored-by: Filippo <[email protected]>
Co-authored-by: Filippo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.