Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine OpenGov doc #5513

Merged
merged 8 commits into from
Jan 18, 2024
Merged

Refine OpenGov doc #5513

merged 8 commits into from
Jan 18, 2024

Conversation

DrW3RK
Copy link
Member

@DrW3RK DrW3RK commented Jan 15, 2024

  • Remove ambiguity on Approval computation
  • Move conviction voting section above approval/support section (as calculation example requires understanding of it)
  • Add a simple example computing approval and support

@DrW3RK DrW3RK self-assigned this Jan 15, 2024
@DrW3RK DrW3RK added the A1 - In Progress Not ready for review yet. label Jan 15, 2024
@DrW3RK DrW3RK added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Jan 17, 2024
Copy link
Contributor

@filippoweb3 filippoweb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions. Additionally, I would present the example with bullet points. It eases the read.

docs/learn/learn-polkadot-opengov.md Outdated Show resolved Hide resolved
docs/learn/learn-polkadot-opengov.md Outdated Show resolved Hide resolved
docs/learn/learn-polkadot-opengov.md Outdated Show resolved Hide resolved
docs/learn/learn-polkadot-opengov.md Outdated Show resolved Hide resolved
@DrW3RK DrW3RK merged commit 747be27 into master Jan 18, 2024
2 checks passed
@DrW3RK DrW3RK deleted the refine-OpenGov branch January 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants