repo_rule_import: convoluted "min" repro for glob / list mismatch #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key distinction is that a list of
srcs = ["a", "b"]
has different behaviour than
srcs = glob(["a", "b"])
Specifically, the latter matches no files.
wade-arista
force-pushed
the
extfiles
branch
from
a345c60 to
88afa07
Compare
wade-arista
force-pushed
the
main
branch
3 times, most recently
from
c789cc6 to
144d772
Compare
wade-arista
force-pushed
the
main
branch
3 times, most recently
from
d22e149 to
8ce2e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key distinction is that a list of
has different behaviour than
Specifically, the latter matches no files.