Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with non-default dayborder in part 5 #1008

Merged
merged 8 commits into from
Jan 11, 2024

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Dec 21, 2023

This PR fixes #1006
The problem was that g.part5.definedays.R() did not correctly expand object nightsi. @jhmigueles this relates to the qwindow implementation in part 5 you did, so it would be good if you could check that this does not break any functionality you intended.

Further, in this PR includes minor fixes:

  • Correct assumption by g.part5.definedays.R() that "00:00:00" is always the start of a MM segment.
  • I removed some of the cat() statements that are not informative for the user, also I opened a new issue Make code less verbose and review need for cat() statements #1007 to do a more systematic review of this in the new year
  • I changed the ordering of the part 5 report rows, because for the segment report it was not doing the ordering correct.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.

@vincentvanhees vincentvanhees marked this pull request as ready for review December 21, 2023 17:20
Copy link
Collaborator

@jhmigueles jhmigueles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works well after several tests with segments and different dayborders.

In the tests I observed a minor issue which triggers an error when ID cannot be matched with the IDs available in the activity log. I have done a commit that addresses this issue.

@vincentvanhees vincentvanhees merged commit 143d3d1 into master Jan 11, 2024
10 checks passed
@vincentvanhees vincentvanhees deleted the issue1006_dayborder_part5 branch January 11, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-default dayborder messes up results in part 5
2 participants