Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct daysleeper detection and handling in the absence of a sleeplog #1166

Merged
merged 8 commits into from
Jul 1, 2024

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Jul 1, 2024

Fixes #1165

I have tested this with example files with known daysleeper pattern both with and without sleeplog.
Further, I evaluated it by looking at both visualreport and nightsummary output.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Clean code has been attempted, e.g. intuitive object names and no code redundancy.
  • Documentation updated:
    • Function documentation
    • Chapter vignettes for GitHub IO
    • Vignettes for CRAN
  • Corresponding issue tagged in PR message. If no issue exist, please create an issue and tag it.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.
  • GGIR parameters were added/removed. If yes, please also complete checklist below.

@vincentvanhees vincentvanhees marked this pull request as ready for review July 1, 2024 09:52
Copy link
Collaborator

@jhmigueles jhmigueles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to also work well in the sample file that I got.

@vincentvanhees vincentvanhees merged commit b338ba3 into master Jul 1, 2024
7 checks passed
@vincentvanhees vincentvanhees deleted the issue1165_fix_daysleeper_handling branch July 8, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

daysleeper not working correctly when no sleeplog used
2 participants