logout을 UserHandler로 이동 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asp345
requested review from
davin111,
Hank-Choi and
SeonghaeJo
and removed request for
a team
Hank-Choi
approved these changes
Mar 4, 2025
Comment on lines
-77
to
-83
| handle(req) { | ||
| val userId = req.userId | ||
| val logoutRequest: LogoutRequest = req.awaitBodyOrNull() ?: throw ServerWebInputException("Invalid body") | ||
| userService.logout(userId, logoutRequest) | ||
|
|
||
| OkResponse() | ||
| } |
There was a problem hiding this comment.
handle(req, additionalMiddleware = snuttRestApiDefaultMiddleware) {
val userId = req.userId
val logoutRequest: LogoutRequest = req.awaitBodyOrNull() ?: throw ServerWebInputException("Invalid body")
userService.logout(userId, logoutRequest)
OkResponse()
}메소드에 추가할 수 있도록 handle 함수를 만들긴 했습니다.
There was a problem hiding this comment.
둘 다 큰 상관없어보이는데
도메인 맥락을 따를지 코드 맥락을 따를지 결정해주세요
There was a problem hiding this comment.
넵 UserHandler에 있는게 자연스러운거 같아서 원래대로 반영할게요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존 logout api가 AuthHandler에 위치했는데 이게 SnuttRestApiNoAuthMiddleware를 사용하고 있어서 요청의 유저 토큰을 가져오지 못했고 로그아웃이 안됐었어요
경로는 그대로 두고 UserHandler로 옮겨서 제대로 작동하게 만들었습니다