This repository has been archived by the owner on Dec 11, 2021. It is now read-only.
Bemify CSS #6
Merged
Bemify CSS #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BertrandBordage
approved these changes
Mar 10, 2019
| @@ -0,0 +1,24 @@ | |||
| $grid-gutter-width: 30px; | |||
| $header-padding: 6px 8px; | |||
There was a problem hiding this comment.
This is not possible, because $header-padding * 2 is used later in the code.
Unfortunately, SASS doesn’t handle this by multiplying both values, so the build is not working.
I’m merging this work anyway, I fixed it locally and will push the fix.
There was a problem hiding this comment.
Huh odd I didn't notice that one! Thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've left some more detailed notes in #4 on what specific issues this PR addresses and some of the deviations from the feedback I took.
There are a few components I'd prefer to have broken down further but I didn't think it was worth the (fairly significant) changes to the JS to do so. I've left comments where this was particularly apparent. However I think the CSS is much easier to parse now and is all name spaced so should mean we can iterate on changes more quickly without things breaking beneath us as much.
Commit
74548abhas work that goes with BertrandBordage/wagtail#2 to remove as much reset styling from Wagtail core.