Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wagtail 4.1
Regarding Wagtail 4.1 upgrade considerations, we'll need to run the
rebuild_references_index
command.Other than that, the changes made on this commit to the
CopyPageForTranslationAction
would make the build fail with adjango.core.exceptions.AppRegistryNotReady: Apps aren't loaded yet.
error. I have updated the code to apply the patches after apps are installed.Wagtail 4.2
The only change was adding a new migration file for the custom image model: Upgrade considerations
Wagtail 5.0
Updated imports for
wagtailsearch.Query
- Upgrade considerations.We may need to run the
copy_daily_hits_from_wagtailsearch
command. See https://docs.wagtail.org/en/latest/releases/5.0.html#migration-commandMisc
updatemodulepaths
commandwagtail-localize
to 1.6The requirements section on the
wagtail-localize
repo specifiesWagtail (4.1, 4.2, 5.0)
so I suspect we'll delay upgrading to 5.1 then 5.2 for a later moment.