Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail upgrade #362

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Wagtail upgrade #362

merged 7 commits into from
Nov 2, 2023

Conversation

Tijani-Dia
Copy link
Collaborator

@Tijani-Dia Tijani-Dia commented Oct 30, 2023

Wagtail 4.1

Regarding Wagtail 4.1 upgrade considerations, we'll need to run the rebuild_references_index command.

Other than that, the changes made on this commit to the CopyPageForTranslationAction would make the build fail with a django.core.exceptions.AppRegistryNotReady: Apps aren't loaded yet. error. I have updated the code to apply the patches after apps are installed.

Wagtail 4.2

The only change was adding a new migration file for the custom image model: Upgrade considerations

Wagtail 5.0

Updated imports for wagtailsearch.Query - Upgrade considerations.
We may need to run the copy_daily_hits_from_wagtailsearch command. See https://docs.wagtail.org/en/latest/releases/5.0.html#migration-command

Misc

  • Ran the updatemodulepaths command
  • Upgraded wagtail-localize to 1.6

The requirements section on the wagtail-localize repo specifies Wagtail (4.1, 4.2, 5.0) so I suspect we'll delay upgrading to 5.1 then 5.2 for a later moment.

@Tijani-Dia Tijani-Dia changed the title Upgrade Wagtail to 4.1 Wagtail upgrade Oct 30, 2023
@Tijani-Dia Tijani-Dia linked an issue Oct 30, 2023 that may be closed by this pull request
@Tijani-Dia Tijani-Dia marked this pull request as ready for review October 31, 2023 11:17
@Tijani-Dia Tijani-Dia assigned Tijani-Dia and unassigned Tijani-Dia Oct 31, 2023
@thibaudcolas thibaudcolas merged commit 890b057 into main Nov 2, 2023
6 checks passed
@thibaudcolas thibaudcolas deleted the upgrade/wagtail-4.1 branch November 2, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wagtail 4.0 -> 5.1 upgrade + 5.2
2 participants