-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Calibre's image actions to compress images in PRs #359
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
14fb6c8
adding calibre image actions to compress images in PRs - #353
udbhavsomani 9cf2084
adding style linting
udbhavsomani dd42fcc
testing compression
udbhavsomani bf81875
testing compression
udbhavsomani d80fac4
testing compression - 3
udbhavsomani 8e01796
Optimised images with calibre/image-actions
github-actions[bot] 3a0c236
removed images added to test compression
udbhavsomani bf7194a
Merge pull request #1 from udbhavsomani/test
udbhavsomani 950869a
Update .github/workflows/calibreapp-image-actions.yml
udbhavsomani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
name: Compress Images | ||
on: | ||
pull_request: | ||
paths: | ||
- '**.jpg' | ||
- '**.jpeg' | ||
- '**.png' | ||
- '**.webp' | ||
jobs: | ||
build: | ||
# Only run on Pull Requests within the same repository, and not from forks. | ||
# if: github.event.pull_request.head.repo.full_name == github.repository | ||
name: calibreapp/image-actions | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout Repo | ||
uses: actions/checkout@v3 | ||
|
||
- name: Compress Images | ||
uses: calibreapp/image-actions@main | ||
with: | ||
githubToken: ${{ secrets.GITHUB_TOKEN }} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because of the limitations described in https://github.com/calibreapp/image-actions#process-pull-requests-from-forked-repositories
so https://github.com/calibreapp/image-actions#combined-workflow is probably the best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zerolab sure, I'll uncomment this, do you also want me to add cronjobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/calibreapp/image-actions#combined-workflow is the one that we want