refactor: use peerInfo and multiaddresses instead of peerID #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
force-pushed
the
peerInfo
branch
from
1ed0036 to
498022a
Compare
richard-ramos
force-pushed
the
peerInfo
branch
from
498022a to
953a82a
Compare
richard-ramos
force-pushed
the
peerInfo
branch
from
953a82a to
bf357f2
Compare
richard-ramos
changed the title
Ivansete-status
approved these changes
Jan 22, 2025
| @@ -352,7 +352,7 @@ func AddPeer(instance *WakuInstance, address string, protocolID string) (string, | |||
| return "", err | |||
| } | |||
|
|
|||
| peerID, err := instance.node.AddPeer(ma, peerstore.Static, instance.relayTopics, libp2pProtocol.ID(protocolID)) | |||
| peerID, err := instance.node.AddPeer([]multiaddr.Multiaddr{ma}, peerstore.Static, instance.relayTopics, libp2pProtocol.ID(protocolID)) | |||
There was a problem hiding this comment.
Would it be possible to avoid that "cast" , []multiaddr.Multiaddr{...}? Maybe we can make it once within the AddPeer func.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by status-im/status-go#5946
The interaction with libwaku is done thru multiaddresses instead of peerID, because the peerstore is not exposed like we do in go-waku. So, to make it possible to use both go-waku and nwaku in status-go (depending on a build flag), changes are done both in go-waku and the
apipackage to use multiaddresses and/or peer.AddrInfo where needed.It's worth mentioning that the cases in which a
peer.AddrInfoare those in which a node can have more than one multiaddress (like the storenodes), and in these cases thepeer.AddrInfowill be translated into a comma separated string containing all the multiaddresses like it is done here: https://github.com/status-im/status-go/blob/1348510acfdfd93dbe5fc5b0a23e9caf532272a3/wakuv2/nwaku.go#L2904-L2910This PR should not be merged until status-im/status-go#5946 is ready to be merged
cc: @Ivansete-status @gabrielmer