refactor: move --generate-key to a generate-key subcommand #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (17)
|
richard-ramos
force-pushed
the
refactor_key_file
branch
3 times, most recently
from
4a680b4
to
dbc541c
Compare
| Overwrite = altsrc.NewBoolFlag(&cli.BoolFlag{ | ||
| Name: "overwrite", | ||
| Usage: "Overwrite the nodekey file if it already exists", | ||
| Destination: &Options.Overwrite, |
There was a problem hiding this comment.
Maybe set default to false.
|
Good idea to split this into a separate command! |
richard-ramos
force-pushed
the
refactor_key_file
branch
from
dbc541c
to
e0eed78
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the logic to generate a key file to its own subcommand, instead of using a flag.
To generate a nodekey file, you can execute the following command: