Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code scan alerts #664

Merged
merged 5 commits into from
Aug 22, 2023
Merged

fix: code scan alerts #664

merged 5 commits into from
Aug 22, 2023

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Aug 22, 2023

Description

Fixed code scanning alerts and security vulnerability reported.

Changes

  • Remove LGTM alert section in Readme
  • fix code scalling alert
  • Upgrade libp2p to 0.29.2 to avoid security vulnerability reported
  • Updated gitignore to not consider example bins and build directories

Note: Did not update to latest go-libp2p which is v0.30 as it drops compatibility with go.1.19. Need to confirm if we are dependent on this go version anywhere and then update to latest version of libp2p. @richard-ramos , please confirm

Tests

  • Ran all unit tests locally

@status-im-auto
Copy link

status-im-auto commented Aug 22, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ be5bc59 #1 2023-08-22 05:11:31 ~31 sec nix-flake 📄log
✔️ be5bc59 #1 2023-08-22 05:12:24 ~1 min linux 📦deb
✔️ be5bc59 #1 2023-08-22 05:13:55 ~2 min tests 📄log
✔️ be5bc59 #1 2023-08-22 05:14:00 ~2 min tests 📄log
✔️ be5bc59 #1 2023-08-22 05:15:06 ~4 min android 📦tgz
✔️ be5bc59 #1 2023-08-22 05:16:08 ~5 min ios 📦tgz
✔️ d48290a #2 2023-08-22 05:15:39 ~34 sec linux 📦deb
✔️ d48290a #2 2023-08-22 05:17:13 ~2 min nix-flake 📄log
✔️ d48290a #2 2023-08-22 05:18:01 ~2 min tests 📄log
✔️ d48290a #2 2023-08-22 05:18:16 ~3 min tests 📄log
✔️ d48290a #2 2023-08-22 05:19:04 ~3 min android 📦tgz
✔️ d48290a #2 2023-08-22 05:19:15 ~4 min ios 📦tgz

@richard-ramos richard-ramos changed the title Fix/code scan alerts fix: code scan alerts Aug 22, 2023
@chaitanyaprem chaitanyaprem merged commit 54c0221 into master Aug 22, 2023
2 checks passed
@chaitanyaprem chaitanyaprem deleted the fix/code-scan-alerts branch August 22, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants