Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rln-relay): RLN DB should be aware of chain and contract address #670

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

richard-ramos
Copy link
Member

Description

See waku-org/nwaku#1921 for reasoning behind this fix

Changes

  • Adds chainID and contract address to RLN metadata
  • Adds test unit to verify metadata serialization
  • Returns an error during startup if metadata does not match configuration settings

Issue

part of #655

@status-im-auto
Copy link

status-im-auto commented Aug 23, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 24b049a #1 2023-08-23 14:51:05 ~1 min linux 📦deb
✖️ 24b049a #1 2023-08-23 14:51:52 ~1 min tests 📄log
✔️ 24b049a #1 2023-08-23 14:52:11 ~2 min nix-flake 📄log
✖️ 24b049a #1 2023-08-23 14:52:40 ~2 min tests 📄log
✔️ 24b049a #1 2023-08-23 14:54:00 ~4 min android 📦tgz
✔️ 24b049a #1 2023-08-23 14:54:36 ~4 min ios 📦tgz
✔️ fa7ffb7 #2 2023-08-23 16:08:01 ~35 sec linux 📦deb
✔️ fa7ffb7 #2 2023-08-23 16:09:29 ~2 min nix-flake 📄log
✔️ fa7ffb7 #2 2023-08-23 16:10:31 ~3 min tests 📄log
✔️ fa7ffb7 #2 2023-08-23 16:10:38 ~3 min tests 📄log
✔️ fa7ffb7 #2 2023-08-23 16:10:46 ~3 min android 📦tgz
✔️ fa7ffb7 #2 2023-08-23 16:12:38 ~5 min ios 📦tgz

@rymnc
Copy link

rymnc commented Aug 23, 2023

wow, this was really quick! Kudos!

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit 5422af8 into master Aug 24, 2023
2 checks passed
@richard-ramos richard-ramos deleted the fix/persist branch August 24, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants