Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: change all instances of PubSubTopic to PubsubTopic #1703

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

danisharora099
Copy link
Collaborator

@danisharora099 danisharora099 commented Nov 6, 2023

Follow up to #1653 and #1697 (review)

Followup TODO:

@danisharora099 danisharora099 force-pushed the chore/pubusb-topic-namespace branch 2 times, most recently from 16ec137 to e2e498d Compare November 6, 2023 06:49
Copy link

github-actions bot commented Nov 6, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 83.85 KB (-0.01% 🔽) 1.7 s (-0.01% 🔽) 953 ms (+6.43% 🔺) 2.7 s
Waku Simple Light Node 264.26 KB (-0.01% 🔽) 5.3 s (-0.01% 🔽) 1.9 s (-5.5% 🔽) 7.2 s
ECIES encryption 79.46 KB (-0.01% 🔽) 1.6 s (-0.01% 🔽) 1.4 s (+56.22% 🔺) 3 s
Symmetric encryption 79.46 KB (-0.01% 🔽) 1.6 s (-0.01% 🔽) 1.3 s (+5.17% 🔺) 2.8 s
DNS discovery 111.23 KB (0%) 2.3 s (0%) 1.7 s (+30.23% 🔺) 3.9 s
Privacy preserving protocols 131.77 KB (-0.01% 🔽) 2.7 s (-0.01% 🔽) 2 s (+66.83% 🔺) 4.6 s
Light protocols 81.61 KB (-0.01% 🔽) 1.7 s (-0.01% 🔽) 535 ms (-17.39% 🔽) 2.2 s
History retrieval protocols 80.53 KB (-0.01% 🔽) 1.7 s (-0.01% 🔽) 992 ms (+17.54% 🔺) 2.7 s
Deterministic Message Hashing 5.65 KB (0%) 113 ms (0%) 215 ms (-28.68% 🔽) 328 ms

@danisharora099 danisharora099 force-pushed the chore/pubusb-topic-namespace branch from e2e498d to 6f9f98b Compare November 6, 2023 07:27
@danisharora099 danisharora099 marked this pull request as ready for review November 6, 2023 07:34
@danisharora099 danisharora099 requested a review from a team as a code owner November 6, 2023 07:34
@danisharora099 danisharora099 force-pushed the chore/pubusb-topic-namespace branch 2 times, most recently from e2d27d0 to 6f9f98b Compare November 8, 2023 14:10
Copy link
Member

@adklempner adklempner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@danisharora099 danisharora099 merged commit 3166a51 into master Nov 14, 2023
10 of 11 checks passed
@danisharora099 danisharora099 deleted the chore/pubusb-topic-namespace branch November 14, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants