feat: forbid identifiers with camelcase pubSub #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
Here's an example of cases that it catches: |
danisharora099
changed the base branch from
master
to
chore/deprecate-named-pubsub
danisharora099
changed the base branch from
chore/deprecate-named-pubsub
to
chore/pubusb-topic-namespace
danisharora099
force-pushed
the
adklempner/forbid-pubSub
branch
2 times, most recently
from
6aba1b4 to
f41de98
Compare
danisharora099
force-pushed
the
chore/pubusb-topic-namespace
branch
from
e2d27d0 to
6f9f98b
Compare
danisharora099
merged commit f10dc81
into
chore/pubusb-topic-namespace
23 of 31 checks passed
|
nice! |
danisharora099
added a commit
that referenced
this pull request
Nov 14, 2023
* rename all PubSub patterns * feat: forbid identifiers with camelcase pubSub (#1709) --------- Co-authored-by: Arseniy Klempner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
cspell does not allow flagging of words based on patterns, making it difficult it to enforce usage of
pubsuboverpubSub#1704Solution
Add a rule to eslint the use of any identifier which contains the string
pubSuborPubSub.From this point on, any commits that include an identifier which matches the above condition will be caught via pre commit hook. This does not apply to files which are not checked by eslint, and does not catch the pattern if it's used outside of an identifier (e.g. comments or string literals)
Notes