chore(lightpush)!: move protocol implementation to @waku/sdk (1/n)
#1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moves `SubscriptionManager` to `sdk` side
also update peer deps in sdk
danisharora099
changed the title
@waku/sdk (1/n)
3 tasks
39 tasks
size-limit report 📦
|
danisharora099
commented
Apr 18, 2024
Comment on lines
+19
to
+23
| class LightPushSDK extends BaseProtocolSDK implements ILightPushSDK { | ||
| public readonly protocol: LightPushCore; | ||
|
|
||
| constructor(libp2p: Libp2p, options?: ProtocolCreateOptions) { | ||
| super({ numPeersToUse: options?.numPeersToUse ?? DEFAULT_NUM_PEERS }); | ||
| super({ numPeersToUse: options?.numPeersToUse }); |
There was a problem hiding this comment.
note: this is a side-change
adklempner
reviewed
Apr 18, 2024
| ): void { | ||
| const errors = results | ||
| .filter( | ||
| (result): result is PromiseRejectedResult => |
There was a problem hiding this comment.
Learned something new today about Typescript :-)
adklempner
approved these changes
Apr 18, 2024
|
|
||
| const { contentTopic } = message; | ||
| if (!contentTopic) { | ||
| log.warn("Message has no content topic, skipping"); |
There was a problem hiding this comment.
nit: may be worth adding the hash of the message to the log
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of #1886, the current Filter implementation is quite coupled in terms of the RFC specs + our opinions of using peers, handling subscriptions, etc
Solution
Decouple Filter into
SDKandCoreNotes
@waku/coreshould be as unopinionated as possible #1886Contribution checklist:
!in title if breaks public API;