Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: choose peers from the connected pool, instead of dialing unconnected peers #2096

Closed
wants to merge 3 commits into from
Closed

chore: choose peers from the connected pool, instead of dialing unconnected peers #2096

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a5e3f3
chore: choose peers from the connected pool, instead of dialing them
danisharora099 Aug 6, 2024
5226d3e
Merge branch 'master' into fix/base-protocol
weboko Aug 28, 2024
5d0434d
Merge branch 'master' into fix/base-protocol
weboko Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/sdk/src/protocols/base_protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,6 @@ export class BaseProtocolSDK implements IBaseProtocolSDK {
this.log.info(`Finding and adding ${numPeers} new peers`);
try {
const additionalPeers = await this.findAdditionalPeers(numPeers);
const dials = additionalPeers.map((peer) =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it removed?

this.connectionManager.attemptDial(peer.id)
);

await Promise.all(dials);

const updatedPeers = [...this.peers, ...additionalPeers];
this.updatePeers(updatedPeers);
Expand All @@ -227,10 +222,17 @@ export class BaseProtocolSDK implements IBaseProtocolSDK {
private async findAdditionalPeers(numPeers: number): Promise<Peer[]> {
this.log.info(`Finding ${numPeers} additional peers`);
try {
let newPeers = await this.core.allPeers();
let newPeers = await this.core.getPeers({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try this in practice, e.g dogfooding app?
I used allPeers because getPeers were not returning everything, and was limited for some reason

maxBootstrapPeers: 0,
numPeers: 0
});

if (newPeers.length === 0) {
this.log.warn("No new peers found.");
this.log.warn("No new peers found, trying with bootstrap peers");
newPeers = await this.core.getPeers({
maxBootstrapPeers: numPeers,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't previous line return all bootstrap peers already?
I mean 0 is for returning all peers, right?

numPeers: 0
});
}

newPeers = newPeers
Expand Down
Loading