Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: respect set peers number #2108

Closed
wants to merge 1 commit into from
Closed

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Aug 22, 2024

Problem

Due to this.connectedPeers being used directly -

Solution

Stop using it and cap amount of peers by passed config.

Notes

@weboko weboko requested a review from a team as a code owner August 22, 2024 21:07
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 86.61 KB (+0.02% 🔺) 1.8 s (+0.02% 🔺) 8.1 s (-25.71% 🔽) 9.8 s
Waku Simple Light Node 154 KB (-0.07% 🔽) 3.1 s (-0.07% 🔽) 7.6 s (-51.49% 🔽) 10.7 s
ECIES encryption 22.83 KB (0%) 457 ms (0%) 3.2 s (-9.71% 🔽) 3.7 s
Symmetric encryption 22.33 KB (0%) 447 ms (0%) 1.7 s (-72.77% 🔽) 2.2 s
DNS discovery 72.26 KB (0%) 1.5 s (0%) 4.7 s (-22.04% 🔽) 6.2 s
Peer Exchange discovery 73.79 KB (0%) 1.5 s (0%) 12.1 s (-5% 🔽) 13.6 s
Local Peer Cache Discovery 67.57 KB (0%) 1.4 s (0%) 5.4 s (-39.75% 🔽) 6.8 s
Privacy preserving protocols 38.92 KB (0%) 779 ms (0%) 5.9 s (-3.39% 🔽) 6.7 s
Waku Filter 81.06 KB (+0.08% 🔺) 1.7 s (+0.08% 🔺) 9.3 s (+123.98% 🔺) 11 s
Waku LightPush 78.64 KB (+0.05% 🔺) 1.6 s (+0.05% 🔺) 6 s (-21.33% 🔽) 7.6 s
History retrieval protocols 79.08 KB (+0.06% 🔺) 1.6 s (+0.06% 🔺) 14.9 s (+78.89% 🔺) 16.5 s
Deterministic Message Hashing 7.31 KB (0%) 147 ms (0%) 987 ms (+18.19% 🔺) 1.2 s

@weboko weboko marked this pull request as draft August 22, 2024 21:21
@weboko
Copy link
Collaborator Author

weboko commented Aug 22, 2024

Red herring. It is respected in the latest master but was not at https://lab.waku.org/dogfooding with @waku/[email protected]

@weboko weboko closed this Aug 22, 2024
@weboko weboko deleted the weboko/respect-peers-num branch September 27, 2024 00:19
@weboko weboko restored the weboko/respect-peers-num branch September 27, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant