Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: New PeerExchange protocol cannot decode correctly old rpc #3054

Closed
NagyZoltanPeter opened this issue Sep 24, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@NagyZoltanPeter
Copy link
Contributor

Problem

With v0.33.0-rc2 test we see, that new PeerExchange RPC is not decoded well when request coming from clients using protocol the old way.

Impact

Missing response field is identified as error in case of request RPC.

To reproduce

status.staging fleet testing v0.33.0-rc2 has thousands of this error, no PeerExchange is working there now.

Expected behavior

Response field shall not be handled as mandatory for requests.

Screenshots/logs

image

nwaku version/commit hash

v0.33.0-rc2

@NagyZoltanPeter
Copy link
Contributor Author

Fixed with PR #3055
https://grafana.infra.status.im/d/qrp_ZCTGz/nim-waku-v2?var-host=.%2A&var-fleet=status.staging&var-dc=All
status.staging with v0.33.0-rc3 deployed now serving PX requests.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant