Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: px protocol decode - do not treat missing response field as error #3055

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

NagyZoltanPeter
Copy link
Contributor

Description

With v0.33.0-rc2 on status.staging it was obvious that client using PeerExchange RPC the old way - on request they completely leave out response field (not even default is added) - cause decode error on nwaku side - that now implements changed protocol.

Changes

  • PeerExchangeRpc will not handle missing response field as error.
  • By adding Peer Exchange metrics to grafana dashboard it is better to use counters instead of gauge for better dashboard stats.
  • rpc_codec of WakePeerExchange
  • waku_px_peers_sent and waku_px_errors have changed to counter from gauge type.

Issue

#3054

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3055

Built from f1644f9

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NagyZoltanPeter NagyZoltanPeter merged commit 9b445ac into release/v0.33 Sep 24, 2024
10 of 12 checks passed
@NagyZoltanPeter NagyZoltanPeter deleted the fix-px-protocol-decode branch September 24, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants