fix: px protocol decode - do not treat missing response field as error #3055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With v0.33.0-rc2 on status.staging it was obvious that client using PeerExchange RPC the old way - on request they completely leave out response field (not even default is added) - cause decode error on nwaku side - that now implements changed protocol.
Changes
waku_px_peers_sent
andwaku_px_errors
have changed to counter from gauge type.Issue
#3054