Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove some API message validation checks #2660

Closed
wants to merge 6 commits into from

Conversation

stubbsta
Copy link

@stubbsta stubbsta commented May 2, 2024

Description

DO NOT MERGE, only for RLNv2 epoch testing

Changes

The following message validation checks are commented out:

  • nonceLimit check in nonce_manager.nim
  • message validation in handlers.nim

How to test

  1. This procedure can be used for testing: https://www.notion.so/Waku-RLNv2-Testnet1-d11b3108a6ed4c39b378417db82302a6

Issue

Relates to waku-org/waku-simulator#44

@stubbsta stubbsta requested a review from alrevuelta May 2, 2024 14:24
@stubbsta stubbsta changed the title Remove some API message validation checks (for testing) test: remove some API message validation checks May 2, 2024
Copy link

github-actions bot commented May 2, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2660-rln-v2

Built from d9e02a9

Copy link

github-actions bot commented May 2, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2660-rln-v1

Built from d9e02a9

@alrevuelta
Copy link
Contributor

Looks good. Not meant to be merged but we built this to have an nwaku node that allows to inject messages exceeding the rate limit. Without the commented checks, the node will skip RLN validation and will publish no matter what.

By now we are using the image quay is building and at some point we will switch to waku-spameerrrr

@stubbsta stubbsta force-pushed the remove-nonce-checks-for-testing branch 2 times, most recently from f2c568e to dbc7d55 Compare May 8, 2024 09:16
@stubbsta stubbsta force-pushed the remove-nonce-checks-for-testing branch from c7d0183 to 4af2a78 Compare May 10, 2024 09:15
@Ivansete-status Ivansete-status marked this pull request as draft May 28, 2024 15:03
@Ivansete-status
Copy link
Collaborator

Hey @stubbsta !
Notice that I converted it to draft so that we overlook it.
Cheers

@stubbsta stubbsta force-pushed the remove-nonce-checks-for-testing branch 6 times, most recently from d39a494 to d8934d5 Compare June 6, 2024 13:36
Copy link

github-actions bot commented Jun 6, 2024

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

@stubbsta stubbsta force-pushed the remove-nonce-checks-for-testing branch 7 times, most recently from ff4b1b5 to 19a72c0 Compare June 6, 2024 17:28
@stubbsta stubbsta force-pushed the remove-nonce-checks-for-testing branch from 19a72c0 to cd665cf Compare June 7, 2024 07:08
@alrevuelta alrevuelta changed the base branch from master to rlnv2-only June 7, 2024 07:52
@alrevuelta
Copy link
Contributor

This is deprecated in favour of #2821
That does the same work without requiring an external service to use the API.

@alrevuelta alrevuelta closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants