fix: Use random ports in rest tests instead of fixed ones #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NagyZoltanPeter
requested review from
SionoiS,
darshankabariya,
gabrielmer and
Ivansete-status
|
You can find the image built from this PR at Built from 9142d0e |
|
You can find the image built from this PR at Built from 9142d0e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found that some of the random failures in CI comes from old fashioned REST API tests that use fixed ports for test setup.
Now this changed to OS selected random free ports all remaining places.
I expect more stable CI tests from this change. No functionality changed.
Changes
How to test