Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added message to failed assert #2805

Merged
merged 3 commits into from
Jun 12, 2024
Merged

chore: added message to failed assert #2805

merged 3 commits into from
Jun 12, 2024

Conversation

gabrielmer
Copy link
Contributor

Description

Adding message to failed assert in order to debug this failure in the CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2805-rln-v1

Built from fb9a72a

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2805-rln-v2

Built from fb9a72a

NagyZoltanPeter
NagyZoltanPeter approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let's see how it goes.

@gabrielmer gabrielmer merged commit 15d578a into master Jun 12, 2024
14 of 15 checks passed
@gabrielmer gabrielmer deleted the chore-adding-message-for-failed-assert branch June 12, 2024 20:27
rymnc pushed a commit that referenced this pull request Jun 20, 2024
@gabrielmer @rymnc
added message to failed assert (#2805)
5c84a69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

@SionoiS SionoiS SionoiS approved these changes

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

@darshankabariya darshankabariya Awaiting requested review from darshankabariya

Assignees

@gabrielmer gabrielmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielmer @SionoiS @NagyZoltanPeter